Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update alertmanager flags at runtime #1074

Merged
merged 1 commit into from
Aug 23, 2024
Merged

feat: update alertmanager flags at runtime #1074

merged 1 commit into from
Aug 23, 2024

Conversation

TheSpiritXIII
Copy link
Member

@TheSpiritXIII TheSpiritXIII commented Jul 16, 2024 •
edited

Uses the new config settings instead of CLI flags for alertmanager, and makes StatefulSet UPDATE permissions optional.

@TheSpiritXIII TheSpiritXIII force-pushed the TheSpiritXIII/alertmanager-runtime branch 3 times, most recently from 8d0a80b to a738c88 Compare July 18, 2024 14:26
@TheSpiritXIII TheSpiritXIII force-pushed the TheSpiritXIII/alertmanager-runtime branch from a738c88 to 6e77a35 Compare August 5, 2024 18:09
@TheSpiritXIII TheSpiritXIII mentioned this pull request Aug 5, 2024
Open
@TheSpiritXIII TheSpiritXIII force-pushed the TheSpiritXIII/alertmanager-runtime branch from 6e77a35 to 0b45721 Compare August 5, 2024 18:12
@TheSpiritXIII TheSpiritXIII requested review from bwplotka and pintohutch and removed request for bwplotka August 5, 2024 18:12
@TheSpiritXIII TheSpiritXIII marked this pull request as ready for review August 5, 2024 18:13
@TheSpiritXIII TheSpiritXIII force-pushed the TheSpiritXIII/alertmanager-runtime branch from 0b45721 to 080701a Compare August 7, 2024 19:37
@TheSpiritXIII TheSpiritXIII force-pushed the TheSpiritXIII/alertmanager-runtime branch from 080701a to faaeb81 Compare August 19, 2024 19:55
bwplotka
bwplotka approved these changes Aug 23, 2024
View reviewed changes
Copy link
Collaborator

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! (co-reviewing with @TheSpiritXIII )

@bwplotka bwplotka merged commit 35aa555 into main Aug 23, 2024
27 checks passed
@bwplotka bwplotka deleted the TheSpiritXIII/alertmanager-runtime branch August 23, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwplotka bwplotka bwplotka approved these changes

@pintohutch pintohutch Awaiting requested review from pintohutch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TheSpiritXIII @bwplotka