feat: deprecate the KubeletScraping field (backwards-compatible) #986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheSpiritXIII
force-pushed
the
TheSpiritXIII/deprecate-kubelet
branch
from
3f6ae21
to
8b63511
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps avoid needing to add an
OperatorConfigstatus field, sinceOperatorConfigno longer generates any configurations.Now when
KubeletScrapingis set, aClusterNodeMonitoringobject is created automatically, reducing duplicated code. Users also have more control over the configuration, since they could change default values.Later when we remove
KubeletScraping, users would already have aClusterNodeMonitoringso they will not lose their configurations.