Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AutoML region tags to use standard product prefixes #1669

Merged
merged 1 commit into from
Aug 29, 2018

Conversation

alixhami
Copy link
Contributor

automl_natural_language => automl_language
automl_translation => automl_translate

This update is to be consistent with the Natural Language and Translation region tags.

@alixhami alixhami requested a review from sirtorry August 29, 2018 18:16
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 29, 2018
@alixhami alixhami requested a review from nnegrey August 29, 2018 19:33
Copy link
Contributor

@nnegrey nnegrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alixhami alixhami merged commit 58522c2 into master Aug 29, 2018
@alixhami alixhami deleted the update-automl-region-tags branch August 29, 2018 19:37
@sirtorry
Copy link
Contributor

I actually think we should change everything else to natural_language and translation

@alixhami
Copy link
Contributor Author

Discussed in person with Torry. We will consider making the prefix update in the future if it affects user searching.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants