Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for logging w/ per-request metadata. #1669

Merged
merged 2 commits into from
Mar 29, 2016
Merged

Add support for logging w/ per-request metadata. #1669

merged 2 commits into from
Mar 29, 2016

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Mar 28, 2016

  • insert_id
  • severity
  • http_request

See: #1566.

@tseaver
Add 'severity'/'http_request' attrs to '_BaseEntry'.
36a9520 
Parse from API resource if found.
@tseaver tseaver added the api: logging Issues related to the Cloud Logging API. label Mar 28, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 28, 2016
dhermes
dhermes reviewed Mar 28, 2016
View reviewed changes
gcloud/logging/entries.py
:param severity: (optional) severity of event being logged.

:type http_request: dict or :class:`NoneType`
:param http_request: (optional) info about HTTP request associated with

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@tseaver
Add support for logging w/ per-request metadata.
145cbfb 
- insert_id
- severity
- http_request

See: #1566.
@tseaver
Copy link
Contributor Author

tseaver commented Mar 29, 2016

@dhermes any remaining issues?

@dhermes
Copy link
Contributor

dhermes commented Mar 29, 2016

LGTM

@tseaver tseaver merged commit 79c8e2c into googleapis:logging-api Mar 29, 2016
@tseaver tseaver deleted the logging-support_entry_insertid_severity_httprequest branch March 29, 2016 15:57
@tseaver tseaver mentioned this pull request Mar 30, 2016
Closed
@dhermes dhermes mentioned this pull request Apr 1, 2016
Merged
parthea pushed a commit that referenced this pull request Jul 6, 2023
@alixhami @busunkim96
Update AutoML region tags to use standard product prefixes [(#1669)](G…
fc941e6 
…oogleCloudPlatform/python-docs-samples#1669)
parthea pushed a commit that referenced this pull request Oct 21, 2023
@alixhami @busunkim96
Update AutoML region tags to use standard product prefixes [(#1669)](G…
3ccaa0b 
…oogleCloudPlatform/python-docs-samples#1669)
parthea pushed a commit that referenced this pull request Oct 21, 2023
@alixhami @busunkim96
Update AutoML region tags to use standard product prefixes [(#1669)](G…
623628a 
…oogleCloudPlatform/python-docs-samples#1669)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: logging Issues related to the Cloud Logging API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tseaver @dhermes @googlebot