Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage.cloud-client.requester_pays_test should use a different bucket #3654

Closed
tmatsuo opened this issue Apr 30, 2020 · 0 comments · Fixed by #3655
Closed

storage.cloud-client.requester_pays_test should use a different bucket #3654

tmatsuo opened this issue Apr 30, 2020 · 0 comments · Fixed by #3655
Assignees
@tmatsuo
Labels
api: storage Issues related to the Cloud Storage API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. testing type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@tmatsuo
Copy link
Contributor

tmatsuo commented Apr 30, 2020

Currently storage.cloud-client.requester_pays_test is using the same Storage bucket as other tests.
If the test failed to disable it, many other tests will fail because of this.
@tmatsuo tmatsuo added testing priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. api: storage Issues related to the Cloud Storage API. labels Apr 30, 2020
@tmatsuo tmatsuo self-assigned this Apr 30, 2020
tmatsuo pushed a commit to tmatsuo/python-docs-samples that referenced this issue Apr 30, 2020
[storage] fix: use different bucket for requester_pays_test
8309585 
fixes GoogleCloudPlatform#3654
tmatsuo pushed a commit to tmatsuo/python-docs-samples that referenced this issue Apr 30, 2020
[storage] fix: use a different bucket for requester_pays_test
18e1ef7 
fixes GoogleCloudPlatform#3654
tmatsuo pushed a commit to tmatsuo/python-docs-samples that referenced this issue Apr 30, 2020
[storage] fix: use a different bucket for requester_pays_test
5aa65ca 
fixes GoogleCloudPlatform#3654
@tmatsuo tmatsuo mentioned this issue Apr 30, 2020
Merged
tmatsuo pushed a commit to tmatsuo/python-docs-samples that referenced this issue Apr 30, 2020
[storage] fix: use a different bucket for requester_pays_test
543bf60 
fixes GoogleCloudPlatform#3654
This was referenced Apr 30, 2020
Closed
Closed
Closed
Closed
Closed
Closed
tmatsuo pushed a commit that referenced this issue Apr 30, 2020
[storage] fix: use a different bucket for requester_pays_test (#3655)
dab08ff 
* [storage] fix: use a different bucket for requester_pays_test

fixes #3654

* rename to README.md, added the envvar to the template

* add REQUESTER_PAYS_TEST_BUCKET env var

* just use REQUESTER_PAYS_TEST_BUCKET
tmatsuo pushed a commit that referenced this issue May 1, 2020
[storage] fix: use a different bucket for requester_pays_test (#3655)
a0e9930 
* [storage] fix: use a different bucket for requester_pays_test

fixes #3654

* rename to README.md, added the envvar to the template

* add REQUESTER_PAYS_TEST_BUCKET env var

* just use REQUESTER_PAYS_TEST_BUCKET
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmatsuo tmatsuo

Labels
api: storage Issues related to the Cloud Storage API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. testing type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[storage] fix: use a different bucket for requester_pays_test tmatsuo/python-docs-samples
1 participant
@tmatsuo