Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Add Sample: Events for Cloud Run – Pub/Sub #3928

Closed
grant opened this issue Jun 2, 2020 · 5 comments
Closed

Feat: Add Sample: Events for Cloud Run – Pub/Sub #3928

grant opened this issue Jun 2, 2020 · 5 comments
Assignees
@grant @cumason123
Labels
api: run Issues related to the Cloud Run API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@grant
Copy link
Contributor

grant commented Jun 2, 2020 •
edited
Loading

Add a minimal sample for Events for Cloud Run for Pub/Sub triggers. See the design doc below for more details as to the actual sample:

Resources
@grant grant assigned grant and unassigned leahecole Jun 2, 2020
@grant
Copy link
Contributor Author

grant commented Jun 2, 2020

Curtis, assign yourself after registering on go/github

@grant
Copy link
Contributor Author

grant commented Jun 2, 2020

How does this sound @cumason123?

@cumason123
Copy link
Contributor

Working on it!

@tmatsuo
Copy link
Contributor

tmatsuo commented Jun 2, 2020

@cumason123 FYI, the markdown-preview directory is a nice example for end 2 end testing:
https://github.com/GoogleCloudPlatform/python-docs-samples/tree/master/run/markdown-preview

Feel free to ask anything.

@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Jun 3, 2020
@tmatsuo tmatsuo added api: run Issues related to the Cloud Run API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p2 Moderately-important priority. Fix may not be included in next release. and removed triage me I really want to be triaged. labels Jun 3, 2020
@grant
Copy link
Contributor Author

grant commented Jun 17, 2020

Fixed with #4011.

@grant grant closed this as completed Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@grant grant

@cumason123 cumason123

Labels
api: run Issues related to the Cloud Run API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@tmatsuo @grant @leahecole @cumason123 @yoshi-automation