feat: add run_events_pubsub #1809

grant · 2020-05-18T20:13:34Z

Adds a minimal Events for Cloud Run for Pub/Sub triggers.

Similar to the existing Pub/Sub sample, but uses Events for Cloud Run directly. Worth having a separate sample (at least until GA).

Future samples will be prefixed with:

run_events_{trigger type}
run_events_pubsub
run_events_audit_logs_gcs
run_events_firestore
...etc.

Signed-off-by: Grant Timmerman <timmerman+devrel@google.com>

grant · 2020-05-18T20:17:50Z

I don't understand why the tests have failed for the md preview renderer.

It seems unrelated to this PR.

[ERROR] Failed to get build config
com.google.devtools.kokoro.config.ConfigException: Couldn't find build configuration markdown-preview-renderer under /tmp/workspace/workspace/cloud-devrel/nodejs-docs-samples/presubmit/run/markdown-preview-renderer/src/github/nodejs-docs-samples/.kokoro/run.

That is frustrating.

run/events-pubsub/.gitignore

run/events-pubsub/Dockerfile

run/events-pubsub/README.md

run/events-pubsub/app.js

averikitsch · 2020-05-19T16:01:33Z

I don't understand why the tests have failed for the md preview renderer.

It seems unrelated to this PR.

[ERROR] Failed to get build config
com.google.devtools.kokoro.config.ConfigException: Couldn't find build configuration markdown-preview-renderer under /tmp/workspace/workspace/cloud-devrel/nodejs-docs-samples/presubmit/run/markdown-preview-renderer/src/github/nodejs-docs-samples/.kokoro/run.

That is frustrating.

Looks like we should get those kokoro files merged ASAP @kelsk @grayside

run/events-pubsub/app.js

grayside · 2020-05-19T17:25:11Z

Grant, the failure for markdown-preview-renderer is likely because a CL was submitted to enable testing of a work-in-progress sample, but that sample has not yet been merged.

grayside · 2020-05-19T17:30:14Z

run/README.md

@@ -16,6 +16,7 @@
 |[Cloud SQL (MySQL)][mysql]               | Use MySQL with Cloud Run | - |
 |[Cloud SQL (Postgres)][postgres]         | Use Postgres with Cloud Run | - |
 |[Hello Broken][hello_broken]             | Something is wrong, how do you fix it? | [<img src="https://storage.googleapis.com/cloudrun/button.svg" alt="Run on Google Cloud" height="30"/>][run_button_hello_broken] |
+|[Events – Pub/Sub][events_pubsub]         | Use Pub/Sub with Cloud Run | - |


I think we should have this description parallel the Pub/Sub description more, and be moved right under it. Might want to flag it as alpha if we're going to "advertise" it here.

Suggested change

|[Events – Pub/Sub][events_pubsub] | Use Pub/Sub with Cloud Run | - |

|[Events – Pub/Sub][events_pubsub] | Event-driven service with Events for Cloud Run for Pub/Sub | - |

I agree we can move the Pub/Sub trigger next to the other Pub/Sub sample.

I disagree that we should change the title in this way.
Cloud Run is not_for_ Pub/Sub.
Pub/Sub is a trigger/event type for Cloud Run.

Once public, we should remove the non-native Pub/Sub sample.

The core feedback here is that the two samples should be listed next to each other, and with similar enough structure in their descriptions to make differentiation easy.

Whether one of them is removed at GA is a good question.

run/events-pubsub/README.md

run/events-pubsub/app.js

grant

Thanks for the reviews!

Addressed a few issues.
Need to sync in the design doc a bit more before asking for another review.

grant · 2020-05-19T19:07:04Z

run/README.md

@@ -16,6 +16,7 @@
 |[Cloud SQL (MySQL)][mysql]               | Use MySQL with Cloud Run | - |
 |[Cloud SQL (Postgres)][postgres]         | Use Postgres with Cloud Run | - |
 |[Hello Broken][hello_broken]             | Something is wrong, how do you fix it? | [<img src="https://storage.googleapis.com/cloudrun/button.svg" alt="Run on Google Cloud" height="30"/>][run_button_hello_broken] |
+|[Events – Pub/Sub][events_pubsub]         | Use Pub/Sub with Cloud Run | - |


I agree we can move the Pub/Sub trigger next to the other Pub/Sub sample.

I disagree that we should change the title in this way.
Cloud Run is not_for_ Pub/Sub.
Pub/Sub is a trigger/event type for Cloud Run.

Once public, we should remove the non-native Pub/Sub sample.

run/events-pubsub/.gitignore

run/events-pubsub/Dockerfile

run/events-pubsub/README.md

run/events-pubsub/app.js

Signed-off-by: Grant Timmerman <timmerman+devrel@google.com>

grant · 2020-05-19T19:27:23Z

Grant, the failure for markdown-preview-renderer is likely because a CL was submitted to enable testing of a work-in-progress sample, but that sample has not yet been merged.

OK. Please advise on how to proceed. It's really hard to understand the PR test status if master is failing.

…orm/nodejs-docs-samples into grant_run_events_pubsub

Signed-off-by: Grant Timmerman <timmerman+devrel@google.com>

grant · 2020-05-20T00:05:46Z

I've created GitHub issues for unrelated failing tests.

Signed-off-by: Grant Timmerman <timmerman+devrel@google.com>

grayside · 2020-05-20T15:43:36Z

hello-broken failing is news to me, thanks for filing the issue.

The other two are part of #1752, it seems like Kokoro was configured to expect that PR to already be merged. Note that while it's a failure, it's not a "required" check, so won't block merging.

grayside · 2020-05-20T15:45:34Z

run/README.md

@@ -16,6 +16,7 @@
 |[Cloud SQL (MySQL)][mysql]               | Use MySQL with Cloud Run | - |
 |[Cloud SQL (Postgres)][postgres]         | Use Postgres with Cloud Run | - |
 |[Hello Broken][hello_broken]             | Something is wrong, how do you fix it? | [<img src="https://storage.googleapis.com/cloudrun/button.svg" alt="Run on Google Cloud" height="30"/>][run_button_hello_broken] |
+|[Events – Pub/Sub][events_pubsub]         | Use Pub/Sub with Cloud Run | - |


The core feedback here is that the two samples should be listed next to each other, and with similar enough structure in their descriptions to make differentiation easy.

Whether one of them is removed at GA is a good question.

run/events-pubsub/README.md

run/events-pubsub/app.js

Signed-off-by: Grant Timmerman <timmerman+devrel@google.com>

grant · 2020-05-20T16:29:30Z

@grayside PTAL

feat: add run_events_pubsub

0689b2e

Signed-off-by: Grant Timmerman <timmerman+devrel@google.com>

grant requested a review from grayside May 18, 2020 20:13

googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 18, 2020

grant requested a review from averikitsch May 18, 2020 23:18

averikitsch reviewed May 19, 2020

View reviewed changes

run/events-pubsub/app.js Outdated Show resolved Hide resolved

grayside reviewed May 19, 2020

View reviewed changes

Merge branch 'master' into grant_run_events_pubsub

dbd1ad7

grant commented May 19, 2020

View reviewed changes

fix: address PR issues

59a2b1b

Signed-off-by: Grant Timmerman <timmerman+devrel@google.com>

grant added 2 commits May 19, 2020 16:26

Merge branch 'grant_run_events_pubsub' of github.com:GoogleCloudPlatf…

5ebd594

…orm/nodejs-docs-samples into grant_run_events_pubsub

fix: formalize CE function response

945e490

Signed-off-by: Grant Timmerman <timmerman+devrel@google.com>

grant requested review from grayside and averikitsch May 19, 2020 23:55

This was referenced May 20, 2020

run/hello-broken Test Fails #1817

Closed

run/markdown-preview/editor Test Fails #1818

Closed

run/markdown-preview/renderer Test Fails #1819

Closed

grant added 2 commits May 19, 2020 17:09

fix: add base64 data

8ed1437

Signed-off-by: Grant Timmerman <timmerman+devrel@google.com>

docs: remove bodyparser

9297a61

Signed-off-by: Grant Timmerman <timmerman+devrel@google.com>

averikitsch added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 20, 2020

kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 20, 2020

averikitsch approved these changes May 20, 2020

View reviewed changes

grayside reviewed May 20, 2020

View reviewed changes

docs: address comments about run events pubsub

1e3a92e

Signed-off-by: Grant Timmerman <timmerman+devrel@google.com>

Merge branch 'master' into grant_run_events_pubsub

a101b52

grayside approved these changes May 20, 2020

View reviewed changes

grant added 2 commits May 20, 2020 15:45

Merge branch 'master' into grant_run_events_pubsub

4447a72

Merge branch 'master' into grant_run_events_pubsub

a883e0e

grant merged commit 1fd4f1d into master May 20, 2020

grant deleted the grant_run_events_pubsub branch May 20, 2020 23:11

grant mentioned this pull request Jun 2, 2020

Feat: Add Sample: Events for Cloud Run – Pub/Sub GoogleCloudPlatform/python-docs-samples#3928

Closed

snyk-bot mentioned this pull request Apr 7, 2022

[Snyk] Fix for 1 vulnerabilities ninadhatkar/nodejs-docs-samples#196

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add run_events_pubsub #1809

feat: add run_events_pubsub #1809

grant commented May 18, 2020 •

edited

Loading

grant commented May 18, 2020

averikitsch commented May 19, 2020

grayside commented May 19, 2020

grayside May 19, 2020

grant May 19, 2020

grayside May 20, 2020

grant left a comment

grant May 19, 2020

grant commented May 19, 2020

grant commented May 20, 2020

grayside commented May 20, 2020

grayside May 20, 2020

grant commented May 20, 2020

	\|[Events – Pub/Sub][events_pubsub] \| Use Pub/Sub with Cloud Run \| - \|
	\|[Events – Pub/Sub][events_pubsub] \| Event-driven service with Events for Cloud Run for Pub/Sub \| - \|

feat: add run_events_pubsub #1809

feat: add run_events_pubsub #1809

Conversation

grant commented May 18, 2020 • edited Loading

grant commented May 18, 2020

averikitsch commented May 19, 2020

grayside commented May 19, 2020

grayside May 19, 2020

Choose a reason for hiding this comment

grant May 19, 2020

Choose a reason for hiding this comment

grayside May 20, 2020

Choose a reason for hiding this comment

grant left a comment

Choose a reason for hiding this comment

grant May 19, 2020

Choose a reason for hiding this comment

grant commented May 19, 2020

grant commented May 20, 2020

grayside commented May 20, 2020

grayside May 20, 2020

Choose a reason for hiding this comment

grant commented May 20, 2020

grant commented May 18, 2020 •

edited

Loading