Making travis only test master branch to reduce thrashing. #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
Merging now to prevent thrashing on our new samples migrations. |
theacodes
pushed a commit
that referenced
this pull request
Sep 23, 2015
Making travis only test master branch to reduce thrashing.
nicain
pushed a commit
that referenced
this pull request
Nov 2, 2022
8 tasks
ivanmkc
pushed a commit
that referenced
this pull request
Nov 3, 2022
gcr.io/repo-automation-bots/owlbot-python:latest@sha256:3c3a445b3ddc99ccd5d31edc4b4519729635d20693900db32c4f587ed51f7479
8 tasks
ivanmkc
pushed a commit
that referenced
this pull request
Nov 4, 2022
gcr.io/repo-automation-bots/owlbot-python:latest@sha256:3c3a445b3ddc99ccd5d31edc4b4519729635d20693900db32c4f587ed51f7479
donmccasland
pushed a commit
that referenced
this pull request
Nov 8, 2022
8 tasks
dandhlee
pushed a commit
that referenced
this pull request
Nov 9, 2022
m-strzelczyk
pushed a commit
that referenced
this pull request
Nov 9, 2022
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [google-cloud-storage](https://github.com/googleapis/python-storage) | `==1.41.1` -> `==1.42.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/python-storage</summary> ### [`v1.42.0`](https://github.com/googleapis/python-storage/blob/master/CHANGELOG.md#​1420-httpswwwgithubcomgoogleapispython-storagecomparev1411v1420-2021-08-05) [Compare Source](https://github.com/googleapis/python-storage/compare/v1.41.1...v1.42.0) ##### Features - add 'page_size' parameter to 'Bucket.list_blobs, list_buckets ([#​520](https://www.github.com/googleapis/python-storage/issues/520)) ([c5f4ad8](https://www.github.com/googleapis/python-storage/commit/c5f4ad8fddd1849a4229b0126c4c022bccb90128)) ##### Bug Fixes - **deps:** add explicit ranges for 'google-api-core' and 'google-auth' ([#​530](https://www.github.com/googleapis/python-storage/issues/530)) ([310f207](https://www.github.com/googleapis/python-storage/commit/310f207411da0382af310172344f19c644c14e6a)) - downloading no longer marks metadata fields as 'changed' ([#​523](https://www.github.com/googleapis/python-storage/issues/523)) ([160d1ec](https://www.github.com/googleapis/python-storage/commit/160d1ecb41f1f269b25cb68b2d2f7daf418bf01c)) - make 'requests.exceptions.ChunkedEncodingError retryable by default ([#​526](https://www.github.com/googleapis/python-storage/issues/526)) ([4abb403](https://www.github.com/googleapis/python-storage/commit/4abb40310eca7ec45afc4bc5e4dfafbe083e74d2)) ##### Documentation - update supported / removed Python versions in README ([#​519](https://www.github.com/googleapis/python-storage/issues/519)) ([1f1b138](https://www.github.com/googleapis/python-storage/commit/1f1b138865fb171535ee0cf768aff1987ed58914)) ##### [1.41.1](https://www.github.com/googleapis/python-storage/compare/v1.41.0...v1.41.1) (2021-07-20) ##### Bug Fixes - **deps:** pin `{api,cloud}-core`, `auth` to allow 2.x versions on Python 3 ([#​512](https://www.github.com/googleapis/python-storage/issues/512)) ([4d7500e](https://www.github.com/googleapis/python-storage/commit/4d7500e39c51efd817b8363b69c88be040f3edb8)) - remove trailing commas from error message constants ([#​505](https://www.github.com/googleapis/python-storage/issues/505)) ([d4a86ce](https://www.github.com/googleapis/python-storage/commit/d4a86ceb7a7c5e00ba7bae37c7078d52478040ff)), closes [#​501](https://www.github.com/googleapis/python-storage/issues/501) ##### Documentation - replace usage of deprecated function `download_as_string` in docs ([#​508](https://www.github.com/googleapis/python-storage/issues/508)) ([8dfa4d4](https://www.github.com/googleapis/python-storage/commit/8dfa4d429dce94b671dc3e3755e52ab82733f61a)) </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/python-compute).
8 tasks
msampathkumar
pushed a commit
that referenced
this pull request
Nov 14, 2022
8 tasks
dandhlee
pushed a commit
that referenced
this pull request
Nov 16, 2022
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [google-cloud-storage](https://github.com/googleapis/python-storage) | `==1.41.1` -> `==1.42.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/python-storage</summary> ### [`v1.42.0`](https://github.com/googleapis/python-storage/blob/master/CHANGELOG.md#​1420-httpswwwgithubcomgoogleapispython-storagecomparev1411v1420-2021-08-05) [Compare Source](https://github.com/googleapis/python-storage/compare/v1.41.1...v1.42.0) ##### Features - add 'page_size' parameter to 'Bucket.list_blobs, list_buckets ([#​520](https://www.github.com/googleapis/python-storage/issues/520)) ([c5f4ad8](https://www.github.com/googleapis/python-storage/commit/c5f4ad8fddd1849a4229b0126c4c022bccb90128)) ##### Bug Fixes - **deps:** add explicit ranges for 'google-api-core' and 'google-auth' ([#​530](https://www.github.com/googleapis/python-storage/issues/530)) ([310f207](https://www.github.com/googleapis/python-storage/commit/310f207411da0382af310172344f19c644c14e6a)) - downloading no longer marks metadata fields as 'changed' ([#​523](https://www.github.com/googleapis/python-storage/issues/523)) ([160d1ec](https://www.github.com/googleapis/python-storage/commit/160d1ecb41f1f269b25cb68b2d2f7daf418bf01c)) - make 'requests.exceptions.ChunkedEncodingError retryable by default ([#​526](https://www.github.com/googleapis/python-storage/issues/526)) ([4abb403](https://www.github.com/googleapis/python-storage/commit/4abb40310eca7ec45afc4bc5e4dfafbe083e74d2)) ##### Documentation - update supported / removed Python versions in README ([#​519](https://www.github.com/googleapis/python-storage/issues/519)) ([1f1b138](https://www.github.com/googleapis/python-storage/commit/1f1b138865fb171535ee0cf768aff1987ed58914)) ##### [1.41.1](https://www.github.com/googleapis/python-storage/compare/v1.41.0...v1.41.1) (2021-07-20) ##### Bug Fixes - **deps:** pin `{api,cloud}-core`, `auth` to allow 2.x versions on Python 3 ([#​512](https://www.github.com/googleapis/python-storage/issues/512)) ([4d7500e](https://www.github.com/googleapis/python-storage/commit/4d7500e39c51efd817b8363b69c88be040f3edb8)) - remove trailing commas from error message constants ([#​505](https://www.github.com/googleapis/python-storage/issues/505)) ([d4a86ce](https://www.github.com/googleapis/python-storage/commit/d4a86ceb7a7c5e00ba7bae37c7078d52478040ff)), closes [#​501](https://www.github.com/googleapis/python-storage/issues/501) ##### Documentation - replace usage of deprecated function `download_as_string` in docs ([#​508](https://www.github.com/googleapis/python-storage/issues/508)) ([8dfa4d4](https://www.github.com/googleapis/python-storage/commit/8dfa4d429dce94b671dc3e3755e52ab82733f61a)) </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/python-compute).
8 tasks
telpirion
added a commit
that referenced
this pull request
Nov 16, 2022
* fix: moves import six inside of region tags * fix: moves region tags to show function parameters
dandhlee
pushed a commit
that referenced
this pull request
Nov 18, 2022
* fix: moves import six inside of region tags * fix: moves region tags to show function parameters
engelke
pushed a commit
that referenced
this pull request
Nov 28, 2022
dandhlee
pushed a commit
that referenced
this pull request
Nov 29, 2022
holtskinner
pushed a commit
that referenced
this pull request
Jan 3, 2023
8 tasks
holtskinner
pushed a commit
that referenced
this pull request
Jan 4, 2023
dandhlee
pushed a commit
that referenced
this pull request
Jan 5, 2023
rsamborski
pushed a commit
that referenced
this pull request
Jan 20, 2023
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
8 tasks
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Jan 25, 2023
- feat(samples): private CA python samples - chore(deps): update dependency google-cloud-private-ca to v1 (#89) - chore(deps): update dependency google-cloud-kms to v2.4.1 (#88) - chore(deps): update dependency google-cloud-kms to v2.4.2 (#93) - chore(deps): update dependency google-auth to v1.33.1 (#87) - chore(deps): update dependency google-auth to v1.34.0 (#94) - chore(deps): update dependency google-cloud-kms to v2.4.3 (#96) - chore(deps): update dependency google-cloud-private-ca to v1.0.3 (#97) - feat(samples): add local generation for crypto keys (#98) - chore(deps): update dependency google-cloud-kms to v2.5.0 (#101) - chore: generate python samples templates in owlbot.py (#108) - chore(deps): update dependency cryptography to v3.4.8 (#109) - chore(deps): update dependency google-auth to v2 (#107) - chore(deps): update dependency google-cloud-private-ca to v1.0.4 (#103) - chore(deps): update dependency google-auth to v2.0.2 (#116) - chore(deps): update dependency google-cloud-kms to v2.6.0 (#115) - chore(deps): update dependency pytest to v6.2.5 (#114) - chore: blacken samples noxfile template (#121) - chore: fail samples nox session if python version is missing (#128) - chore(python): Add kokoro configs for python 3.10 samples testing (#134) - chore(deps): update dependency google-auth to v2.1.0 (#120) - chore(deps): update all dependencies (#144) - chore(deps): update all dependencies (#146) - chore(deps): update dependency google-cloud-private-ca to v1.2.1 (#147) - chore(python): run blacken session for all directories with a noxfile (#150) - chore(deps): update dependency cryptography to v36 (#154) - feat(samples): add subordinate CA samples - chore(deps): update dependency cryptography to v36.0.1 (#158) - chore(samples): Add check for tests in directory (#164) - chore(python): Noxfile recognizes that tests can live in a folder (#169) - docs(samples): add sample to filter certificates (#160) - chore(deps): update dependency google-auth to v2.6.0 (#173) - docs(samples): add template/monitoring samples (#174) - chore(deps): update all dependencies (#178) - chore(deps): update all dependencies (#186) - chore: Adding support for pytest-xdist and pytest-parallel (#193) - chore(deps): update all dependencies (#196) - chore(deps): update dependency google-cloud-private-ca to v1.3.0 (#199) - chore(deps): update dependency pytest to v7.1.0 (#200) - chore(deps): update dependency cryptography to v36.0.2 (#201) - chore(deps): update all dependencies (#202) - chore(python): use black==22.3.0 (#204) - chore(deps): update dependency google-auth to v2.6.3 (#211) - chore(deps): update dependency google-auth to v2.6.4 (#215) - chore(deps): update dependency google-auth to v2.6.5 (#217) - chore(python): add nox session to sort python imports (#218) - chore(deps): update dependency google-auth to v2.6.6 (#221) - chore(deps): update dependency pytest to v7.1.2 (#222) - chore(deps): update dependency cryptography to v37 (#223) - chore(deps): update dependency cryptography to v37.0.1 (#225) - chore(deps): update dependency cryptography to v37.0.2 (#226) - chore(deps): update dependency google-cloud-private-ca to v1.3.1 (#230) - fix: require python 3.7+ (#267) - chore(deps): update all dependencies (#262) - chore(deps): update all dependencies (#273) - chore(deps): update all dependencies (#275) - chore(deps): update all dependencies (#276) - chore(deps): update dependency google-cloud-monitoring to v2.11.1 (#281) - chore(deps): update all dependencies (#283) - chore(deps): update dependency google-auth to v2.11.0 (#284) - chore(deps): update dependency pytest to v7.1.3 (#294) - chore: Bump gapic-generator-python version to 1.3.0 (#295) - chore: detect samples tests in nested directories (#299) - chore(deps): update dependency google-auth to v2.11.1 (#300) - chore(deps): update dependency google-auth to v2.12.0 (#302) - chore(deps): update all dependencies (#304) - chore(deps): update all dependencies (#307) - chore(deps): update dependency pytest to v7.2.0 (#308) - chore(deps): update dependency google-auth to v2.14.0 (#310) - chore(python): drop flake8-import-order in samples noxfile (#315) - chore(deps): update all dependencies (#311) - chore(deps): update dependency cryptography to v38.0.4 (#317) - chore(deps): update dependency google-auth to v2.15.0 (#318) - chore(deps): update all dependencies (#321) - chore(deps): update dependency google-cloud-private-ca to v1.5.0 (#322) - chore(deps): update dependency cryptography to v39 (#323) - chore(python): add support for python 3.11 (#324) - chore(deps): update dependency google-cloud-monitoring to v2.13.0 (#325) - chore(deps): update dependency google-auth to v2.16.0 (#326) - chore(deps): update all dependencies (#329) - chore(deps): update dependency pytest to v7.2.1 (#330) ## Description Sample Migration from googleapis/python-security-private-ca Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google. ## Checklist - [ ] I have followed [Sample Guidelines from AUTHORING_GUIDE.MD](https://github.com/GoogleCloudPlatform/python-docs-samples/blob/main/AUTHORING_GUIDE.md) - [ ] README is updated to include [all relevant information](https://github.com/GoogleCloudPlatform/python-docs-samples/blob/main/AUTHORING_GUIDE.md#readme-file) - [ ] **Tests** pass: `nox -s py-3.9` (see [Test Environment Setup](https://github.com/GoogleCloudPlatform/python-docs-samples/blob/main/AUTHORING_GUIDE.md#test-environment-setup)) - [ ] **Lint** pass: `nox -s lint` (see [Test Environment Setup](https://github.com/GoogleCloudPlatform/python-docs-samples/blob/main/AUTHORING_GUIDE.md#test-environment-setup)) - [ ] These samples need a new **API enabled** in testing projects to pass (let us know which ones) - [ ] These samples need a new/updated **env vars** in testing projects set to pass (let us know which ones) - [ ] Please **merge** this PR for me once it is approved. - [ ] This sample adds a new sample directory, and I updated the [CODEOWNERS file](https://github.com/GoogleCloudPlatform/python-docs-samples/blob/main/.github/CODEOWNERS) with the codeowners for this sample
8 tasks
m-strzelczyk
pushed a commit
that referenced
this pull request
Jan 25, 2023
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
telpirion
pushed a commit
that referenced
this pull request
Mar 13, 2023
- feat(samples): private CA python samples - chore(deps): update dependency google-cloud-private-ca to v1 (#89) - chore(deps): update dependency google-cloud-kms to v2.4.1 (#88) - chore(deps): update dependency google-cloud-kms to v2.4.2 (#93) - chore(deps): update dependency google-auth to v1.33.1 (#87) - chore(deps): update dependency google-auth to v1.34.0 (#94) - chore(deps): update dependency google-cloud-kms to v2.4.3 (#96) - chore(deps): update dependency google-cloud-private-ca to v1.0.3 (#97) - feat(samples): add local generation for crypto keys (#98) - chore(deps): update dependency google-cloud-kms to v2.5.0 (#101) - chore: generate python samples templates in owlbot.py (#108) - chore(deps): update dependency cryptography to v3.4.8 (#109) - chore(deps): update dependency google-auth to v2 (#107) - chore(deps): update dependency google-cloud-private-ca to v1.0.4 (#103) - chore(deps): update dependency google-auth to v2.0.2 (#116) - chore(deps): update dependency google-cloud-kms to v2.6.0 (#115) - chore(deps): update dependency pytest to v6.2.5 (#114) - chore: blacken samples noxfile template (#121) - chore: fail samples nox session if python version is missing (#128) - chore(python): Add kokoro configs for python 3.10 samples testing (#134) - chore(deps): update dependency google-auth to v2.1.0 (#120) - chore(deps): update all dependencies (#144) - chore(deps): update all dependencies (#146) - chore(deps): update dependency google-cloud-private-ca to v1.2.1 (#147) - chore(python): run blacken session for all directories with a noxfile (#150) - chore(deps): update dependency cryptography to v36 (#154) - feat(samples): add subordinate CA samples - chore(deps): update dependency cryptography to v36.0.1 (#158) - chore(samples): Add check for tests in directory (#164) - chore(python): Noxfile recognizes that tests can live in a folder (#169) - docs(samples): add sample to filter certificates (#160) - chore(deps): update dependency google-auth to v2.6.0 (#173) - docs(samples): add template/monitoring samples (#174) - chore(deps): update all dependencies (#178) - chore(deps): update all dependencies (#186) - chore: Adding support for pytest-xdist and pytest-parallel (#193) - chore(deps): update all dependencies (#196) - chore(deps): update dependency google-cloud-private-ca to v1.3.0 (#199) - chore(deps): update dependency pytest to v7.1.0 (#200) - chore(deps): update dependency cryptography to v36.0.2 (#201) - chore(deps): update all dependencies (#202) - chore(python): use black==22.3.0 (#204) - chore(deps): update dependency google-auth to v2.6.3 (#211) - chore(deps): update dependency google-auth to v2.6.4 (#215) - chore(deps): update dependency google-auth to v2.6.5 (#217) - chore(python): add nox session to sort python imports (#218) - chore(deps): update dependency google-auth to v2.6.6 (#221) - chore(deps): update dependency pytest to v7.1.2 (#222) - chore(deps): update dependency cryptography to v37 (#223) - chore(deps): update dependency cryptography to v37.0.1 (#225) - chore(deps): update dependency cryptography to v37.0.2 (#226) - chore(deps): update dependency google-cloud-private-ca to v1.3.1 (#230) - fix: require python 3.7+ (#267) - chore(deps): update all dependencies (#262) - chore(deps): update all dependencies (#273) - chore(deps): update all dependencies (#275) - chore(deps): update all dependencies (#276) - chore(deps): update dependency google-cloud-monitoring to v2.11.1 (#281) - chore(deps): update all dependencies (#283) - chore(deps): update dependency google-auth to v2.11.0 (#284) - chore(deps): update dependency pytest to v7.1.3 (#294) - chore: Bump gapic-generator-python version to 1.3.0 (#295) - chore: detect samples tests in nested directories (#299) - chore(deps): update dependency google-auth to v2.11.1 (#300) - chore(deps): update dependency google-auth to v2.12.0 (#302) - chore(deps): update all dependencies (#304) - chore(deps): update all dependencies (#307) - chore(deps): update dependency pytest to v7.2.0 (#308) - chore(deps): update dependency google-auth to v2.14.0 (#310) - chore(python): drop flake8-import-order in samples noxfile (#315) - chore(deps): update all dependencies (#311) - chore(deps): update dependency cryptography to v38.0.4 (#317) - chore(deps): update dependency google-auth to v2.15.0 (#318) - chore(deps): update all dependencies (#321) - chore(deps): update dependency google-cloud-private-ca to v1.5.0 (#322) - chore(deps): update dependency cryptography to v39 (#323) - chore(python): add support for python 3.11 (#324) - chore(deps): update dependency google-cloud-monitoring to v2.13.0 (#325) - chore(deps): update dependency google-auth to v2.16.0 (#326) - chore(deps): update all dependencies (#329) - chore(deps): update dependency pytest to v7.2.1 (#330) ## Description Sample Migration from googleapis/python-security-private-ca Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google. ## Checklist - [ ] I have followed [Sample Guidelines from AUTHORING_GUIDE.MD](https://github.com/GoogleCloudPlatform/python-docs-samples/blob/main/AUTHORING_GUIDE.md) - [ ] README is updated to include [all relevant information](https://github.com/GoogleCloudPlatform/python-docs-samples/blob/main/AUTHORING_GUIDE.md#readme-file) - [ ] **Tests** pass: `nox -s py-3.9` (see [Test Environment Setup](https://github.com/GoogleCloudPlatform/python-docs-samples/blob/main/AUTHORING_GUIDE.md#test-environment-setup)) - [ ] **Lint** pass: `nox -s lint` (see [Test Environment Setup](https://github.com/GoogleCloudPlatform/python-docs-samples/blob/main/AUTHORING_GUIDE.md#test-environment-setup)) - [ ] These samples need a new **API enabled** in testing projects to pass (let us know which ones) - [ ] These samples need a new/updated **env vars** in testing projects set to pass (let us know which ones) - [ ] Please **merge** this PR for me once it is approved. - [ ] This sample adds a new sample directory, and I updated the [CODEOWNERS file](https://github.com/GoogleCloudPlatform/python-docs-samples/blob/main/.github/CODEOWNERS) with the codeowners for this sample
telpirion
pushed a commit
that referenced
this pull request
Mar 13, 2023
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
cojenco
pushed a commit
that referenced
this pull request
Apr 12, 2023
dandhlee
pushed a commit
that referenced
this pull request
Apr 13, 2023
Avani-Thakker-Crest
pushed a commit
to Avani-Thakker-Crest/python-docs-samples
that referenced
this pull request
Apr 14, 2023
Avani-Thakker-Crest
pushed a commit
to Avani-Thakker-Crest/python-docs-samples
that referenced
this pull request
Apr 14, 2023
dizcology
pushed a commit
that referenced
this pull request
Sep 11, 2023
* chore: increased timeout for flaky service & added retry * fixed param error * lint
9 tasks
leahecole
pushed a commit
that referenced
this pull request
Sep 15, 2023
](https://renovatebot.com){kind=link}
* chore: increased timeout for flaky service & added retry * fixed param error * lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @jerjou @tmatsuo