Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print all results, not all alternatives #1098

Merged
merged 1 commit into from
Sep 7, 2017
Merged

Print all results, not all alternatives #1098

merged 1 commit into from
Sep 7, 2017

Conversation

jerjou
Copy link
Contributor

@jerjou jerjou commented Aug 31, 2017

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 31, 2017
@jerjou jerjou changed the title py35(sample='./speech/cloud-client')Print all results, not all alternatives Print all results, not all alternatives Sep 1, 2017
# There could be multiple results in each response.
# The `results` list is consecutive. For streaming, we only care about
# the first result being considered, since once it's `is_final`, it
# moves on to considering the next utterance.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean that there is always only one result in each response of streaming_recognize?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a) What're you doing doing a code review on a holiday?? tsk tsk
b) Mm... if interim_results is False, then yes - there will only be one result. But if interim_results is True, then there can be 0 or one is_final result, followed by 0 to many interim (is_final=False) results. I believe different results correspond to consecutive parts of the audio stream. See here

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see - thanks for the clarification.

Copy link
Member

@dizcology dizcology left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

# There could be multiple results in each response.
# The `results` list is consecutive. For streaming, we only care about
# the first result being considered, since once it's `is_final`, it
# moves on to considering the next utterance.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see - thanks for the clarification.

@jerjou jerjou merged commit cfa07e8 into master Sep 7, 2017
@jerjou jerjou deleted the speech-results branch September 7, 2017 17:27
atulep pushed a commit to googleapis/google-cloud-python that referenced this pull request Apr 6, 2023
atulep pushed a commit to googleapis/google-cloud-python that referenced this pull request Apr 6, 2023
atulep pushed a commit to googleapis/google-cloud-python that referenced this pull request Apr 18, 2023
parthea pushed a commit to googleapis/google-cloud-python that referenced this pull request Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants