-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Cloud Scheduler sample #1968
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, a few optional comments.
scheduler/create_job_test.py
Outdated
|
||
|
||
def test_create_job(capsys): | ||
create_result = create_job.create_scheduler_job(TEST_PROJECT_ID, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider removing the hanging indent:
create_result = create_job.create_scheduler_job(
TEST_PROJECT_ID, TEST_LOCATION, 'my-service')
scheduler/main.py
Outdated
@@ -0,0 +1,42 @@ | |||
# Copyright 2018 Google LLC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Optional) Consider updating to 2019 as this is first publish
…samples#1968) * scheduler sample * scheduler tutorial draft * create and delete requests completed * updated region tag * update error * fix linting * Update styling * Update license * Update license * Update license * Update license
…samples#1968) * scheduler sample * scheduler tutorial draft * create and delete requests completed * updated region tag * update error * fix linting * Update styling * Update license * Update license * Update license * Update license
…samples#1968) * scheduler sample * scheduler tutorial draft * create and delete requests completed * updated region tag * update error * fix linting * Update styling * Update license * Update license * Update license * Update license
No description provided.