Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BigQuery: Add sample for explicitly creating client from service acco… #2312

Merged
merged 5 commits into from
Aug 5, 2019

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Aug 1, 2019

…unt credentials.

We got some feedback that we don't show how to use an explicit credentials argument in our BigQuery authentication samples. We prefer using the credentials argument over using the Client.from_service_account_json, as an explicit credentials argument gives a better indication for how to construct a client with other credentials types as well.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 1, 2019
Copy link
Contributor

@shollyman shollyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps the two functions (authenticate and create_client) should be combined?

@tswast tswast merged commit 1a87fb3 into master Aug 5, 2019
@tswast tswast deleted the b137345293-credentials-argument branch August 5, 2019 22:34
plamut pushed a commit to plamut/python-bigquery that referenced this pull request Jun 25, 2020
…… [(#2312)](GoogleCloudPlatform/python-docs-samples#2312)

* BigQuery: Add sample for explicitly creating client from service account credentials.

* Flake8

* Move imports to improve indentation.

* Combine auth and client functions.

* flake8
plamut pushed a commit to plamut/python-bigquery that referenced this pull request Jul 22, 2020
…… [(#2312)](GoogleCloudPlatform/python-docs-samples#2312)

* BigQuery: Add sample for explicitly creating client from service account credentials.

* Flake8

* Move imports to improve indentation.

* Combine auth and client functions.

* flake8
shollyman pushed a commit to googleapis/python-bigquery that referenced this pull request Jul 22, 2020
…… [(#2312)](GoogleCloudPlatform/python-docs-samples#2312)

* BigQuery: Add sample for explicitly creating client from service account credentials.

* Flake8

* Move imports to improve indentation.

* Combine auth and client functions.

* flake8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants