-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: MP3 file test for Text-to-Speech SSML addresses #2378
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
Sep 4, 2019
crowdus
changed the title
fix: MP3 file test
fix: MP3 file test for Text-to-Speech SSML addresses
Sep 4, 2019
nnegrey
reviewed
Sep 4, 2019
nnegrey
approved these changes
Sep 4, 2019
busunkim96
pushed a commit
to googleapis/python-texttospeech
that referenced
this pull request
Apr 9, 2020
…CloudPlatform/python-docs-samples#2378) * fix: refactored MP3 file tests * fix: moving resources to cloud-client/resources * fix: removing expected_example.mp3
busunkim96
pushed a commit
to googleapis/python-texttospeech
that referenced
this pull request
May 13, 2020
…CloudPlatform/python-docs-samples#2378) * fix: refactored MP3 file tests * fix: moving resources to cloud-client/resources * fix: removing expected_example.mp3
busunkim96
pushed a commit
to googleapis/python-texttospeech
that referenced
this pull request
May 13, 2020
…CloudPlatform/python-docs-samples#2378) * fix: refactored MP3 file tests * fix: moving resources to cloud-client/resources * fix: removing expected_example.mp3
busunkim96
pushed a commit
to googleapis/python-texttospeech
that referenced
this pull request
May 13, 2020
…CloudPlatform/python-docs-samples#2378) * fix: refactored MP3 file tests * fix: moving resources to cloud-client/resources * fix: removing expected_example.mp3
busunkim96
pushed a commit
to googleapis/python-texttospeech
that referenced
this pull request
May 20, 2020
…CloudPlatform/python-docs-samples#2378) * fix: refactored MP3 file tests * fix: moving resources to cloud-client/resources * fix: removing expected_example.mp3
busunkim96
pushed a commit
to googleapis/python-texttospeech
that referenced
this pull request
May 20, 2020
…CloudPlatform/python-docs-samples#2378) * fix: refactored MP3 file tests * fix: moving resources to cloud-client/resources * fix: removing expected_example.mp3
msampathkumar
pushed a commit
that referenced
this pull request
Nov 10, 2022
8 tasks
msampathkumar
pushed a commit
that referenced
this pull request
Nov 10, 2022
parthea
pushed a commit
to googleapis/google-cloud-python
that referenced
this pull request
Sep 22, 2023
…CloudPlatform/python-docs-samples#2378) * fix: refactored MP3 file tests * fix: moving resources to cloud-client/resources * fix: removing expected_example.mp3
parthea
pushed a commit
to googleapis/google-cloud-python
that referenced
this pull request
Sep 22, 2023
…CloudPlatform/python-docs-samples#2378) * fix: refactored MP3 file tests * fix: moving resources to cloud-client/resources * fix: removing expected_example.mp3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b/140437136
In addition to fixing the test, I also moved the samples into the
cloud-client
directory.@nnegrey