Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing functions test #2549

Merged
merged 4 commits into from
Nov 18, 2019
Merged

Fix failing functions test #2549

merged 4 commits into from
Nov 18, 2019

Conversation

leahecole
Copy link
Collaborator

Fix #2548

@leahecole leahecole requested a review from a team as a code owner November 18, 2019 19:20
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 18, 2019
@leahecole leahecole requested a review from ace-n November 18, 2019 19:20
@leahecole
Copy link
Collaborator Author

leahecole commented Nov 18, 2019 •
edited
Loading

I'm running kokoro against the branch - build # 87 in fusion if you want to check on it

@leahecole
Copy link
Collaborator Author

🤦‍♀ oops, I mean 88 because i totally forgot to add the lint fix

ace-n
ace-n approved these changes Nov 18, 2019
View reviewed changes
Copy link

@ace-n ace-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are passing - LGTM.

@kurtisvg kurtisvg merged commit f2dbe79 into master Nov 18, 2019
@kurtisvg kurtisvg deleted the fix-functions-test branch November 18, 2019 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ace-n ace-n ace-n approved these changes

@kurtisvg kurtisvg kurtisvg approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gcf fusion tests failing
4 participants
@leahecole @ace-n @kurtisvg @googlebot