fix: address bigquery/bqml test failures #2920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The BQML tests use a non-unique dataset ID for multiple examples and testing currently triggers a lot of concurrent creation/deletions of said dataset. Switch to a dataset that leverages uuid to avoid invocations stomping on one another, which also necessitates parameterizing much of the SQL. There's also an issue with the pandas import currently, possibly due to recent changes in panda. This change also pins pandas to 0.22 and doesn't rely on the dependency being expressed as an extra through google-cloud-bigquery.
googlebot
added
the
cla: yes
kurtisvg
suggested changes
Feb 14, 2020
kurtisvg
approved these changes
Feb 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The BQML tests use a non-unique dataset ID for multiple examples and
testing currently triggers a lot of concurrent creation/deletions of
said dataset. Switch to a dataset that leverages uuid to avoid
invocations stomping on one another, which also necessitates
parameterizing much of the SQL.
There's also an issue with the pandas import currently, possibly due to
recent changes in panda. This change also pins pandas to 0.22 and
doesn't rely on the dependency being expressed as an extra through
google-cloud-bigquery.