Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dialogflow: remove unused samples + tests #3249

Merged
merged 19 commits into from
Apr 23, 2020
Merged

dialogflow: remove unused samples + tests #3249

merged 19 commits into from
Apr 23, 2020

Conversation

Strykrol
Copy link
Contributor

@Strykrol Strykrol commented Apr 1, 2020

No description provided.

@Strykrol
dialogflow: delete unused samples and corresponding tests for context…
0f238f5 
… management
@Strykrol
dialogflow: delete unused samples and corresponding tests for detecti…
fafcd49 
…ng intent with model selection
@Strykrol
dialogflow: delete unused samples for document management
334e66e
@Strykrol
dialogflow: clean up document management whitespace
7120305
@Strykrol
dialogflow: delete unused samples for entity management
53ad425
@Strykrol
dialogflow: delete tests for deleted entity management samples
a591a03
@Strykrol
dialogflow: delete tests for deleted document management samples
94abfa3
@Strykrol
dialogflow: delete unused samples and corresponding tests for entity …
5b0831a 
…type management
@Strykrol
dialogflow: delete unused samples and corresponding tests for session…
5de592c 
… entity type management and entity type management
@Strykrol
dialogflow: delete unused samples and corresponding tests for knowled…
2ae14ba 
…ge base management
@Strykrol Strykrol requested review from nnegrey, sirtorry, telpirion and a team as code owners April 1, 2020 20:00
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 1, 2020
@tmatsuo tmatsuo mentioned this pull request Apr 23, 2020
Closed
@tmatsuo tmatsuo added the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 23, 2020
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 23, 2020
@tmatsuo tmatsuo added the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 23, 2020
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 23, 2020
@tmatsuo
Copy link
Contributor

tmatsuo commented Apr 23, 2020

@Strykrol Here is the lint output:

./document_management.py:34:1: E302 expected 2 blank lines, found 1
def create_document(project_id, knowledge_base_id, display_name, mime_type,
^
./document_management.py:73:1: E305 expected 2 blank lines after class or function definition, found 1
if __name__ == '__main__':
^
./document_management.py:113:42: W292 no newline at end of file
                        args.content_uri)                                         ^
./knowledge_base_management.py:70:66: W292 no newline at end of file
        create_knowledge_base(args.project_id, args.display_name)                                                                 ^

@Strykrol
Copy link
Contributor Author

Got it, fixing...

@tmatsuo tmatsuo added kokoro:run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. labels Apr 23, 2020
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 23, 2020
@tmatsuo
Copy link
Contributor

tmatsuo commented Apr 23, 2020

A flake filed: #3490
Restarting the build

@tmatsuo tmatsuo added kokoro:run Add this label to force Kokoro to re-run the tests. and removed kokoro:run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. labels Apr 23, 2020
@tmatsuo tmatsuo merged commit cc2e237 into GoogleCloudPlatform:master Apr 23, 2020
@tmatsuo
Copy link
Contributor

tmatsuo commented Apr 23, 2020

@Strykrol Thanks! It's finally merged :)

@Strykrol
Copy link
Contributor Author

Thank you for taking it to the finish line!

leahecole added a commit that referenced this pull request Apr 24, 2020
@Strykrol @leahecole
dialogflow: remove unused samples + tests (#3249)
ab1532b 
* dialogflow: delete unused samples and corresponding tests for context management

* dialogflow: delete unused samples and corresponding tests for detecting intent with model selection

* dialogflow: delete unused samples for document management

* dialogflow: clean up document management whitespace

* dialogflow: delete unused samples for entity management

* dialogflow: delete tests for deleted entity management samples

* dialogflow: delete tests for deleted document  management samples

* dialogflow: delete unused samples and corresponding tests for entity type management

* dialogflow: delete unused samples and corresponding tests for session entity type management and entity type management

* dialogflow: delete unused samples and corresponding tests for knowledge base management

* flake8 lints

Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
@tmatsuo tmatsuo mentioned this pull request Apr 25, 2020
Closed
@Strykrol Strykrol deleted the snippetcleanup branch April 28, 2020 17:29
busunkim96 pushed a commit to busunkim96/dialogflow-python-client-v2 that referenced this pull request Nov 30, 2020
@Strykrol @leahecole
dialogflow: remove unused samples + tests [(#3249)](GoogleCloudPlatfo…
847fcd6 
…rm/python-docs-samples#3249)

* dialogflow: delete unused samples and corresponding tests for context management

* dialogflow: delete unused samples and corresponding tests for detecting intent with model selection

* dialogflow: delete unused samples for document management

* dialogflow: clean up document management whitespace

* dialogflow: delete unused samples for entity management

* dialogflow: delete tests for deleted entity management samples

* dialogflow: delete tests for deleted document  management samples

* dialogflow: delete unused samples and corresponding tests for entity type management

* dialogflow: delete unused samples and corresponding tests for session entity type management and entity type management

* dialogflow: delete unused samples and corresponding tests for knowledge base management

* flake8 lints

Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
busunkim96 pushed a commit to googleapis/python-dialogflow that referenced this pull request Dec 9, 2020
@Strykrol @leahecole @busunkim96
dialogflow: remove unused samples + tests [(#3249)](GoogleCloudPlatfo…
98fa83d 
…rm/python-docs-samples#3249)

* dialogflow: delete unused samples and corresponding tests for context management

* dialogflow: delete unused samples and corresponding tests for detecting intent with model selection

* dialogflow: delete unused samples for document management

* dialogflow: clean up document management whitespace

* dialogflow: delete unused samples for entity management

* dialogflow: delete tests for deleted entity management samples

* dialogflow: delete tests for deleted document  management samples

* dialogflow: delete unused samples and corresponding tests for entity type management

* dialogflow: delete unused samples and corresponding tests for session entity type management and entity type management

* dialogflow: delete unused samples and corresponding tests for knowledge base management

* flake8 lints

Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
telpirion pushed a commit that referenced this pull request Jan 18, 2023
@Strykrol @leahecole @busunkim96
dialogflow: remove unused samples + tests [(#3249)](#3249)
0885178 
* dialogflow: delete unused samples and corresponding tests for context management

* dialogflow: delete unused samples and corresponding tests for detecting intent with model selection

* dialogflow: delete unused samples for document management

* dialogflow: clean up document management whitespace

* dialogflow: delete unused samples for entity management

* dialogflow: delete tests for deleted entity management samples

* dialogflow: delete tests for deleted document  management samples

* dialogflow: delete unused samples and corresponding tests for entity type management

* dialogflow: delete unused samples and corresponding tests for session entity type management and entity type management

* dialogflow: delete unused samples and corresponding tests for knowledge base management

* flake8 lints

Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
@telpirion telpirion mentioned this pull request Jan 18, 2023
Closed
8 tasks
@yil532 yil532 mentioned this pull request Feb 1, 2023
Merged
8 tasks
dandhlee pushed a commit that referenced this pull request Feb 6, 2023
@Strykrol @leahecole @dandhlee
dialogflow: remove unused samples + tests [(#3249)](#3249)
ab6f591 
* dialogflow: delete unused samples and corresponding tests for context management

* dialogflow: delete unused samples and corresponding tests for detecting intent with model selection

* dialogflow: delete unused samples for document management

* dialogflow: clean up document management whitespace

* dialogflow: delete unused samples for entity management

* dialogflow: delete tests for deleted entity management samples

* dialogflow: delete tests for deleted document  management samples

* dialogflow: delete unused samples and corresponding tests for entity type management

* dialogflow: delete unused samples and corresponding tests for session entity type management and entity type management

* dialogflow: delete unused samples and corresponding tests for knowledge base management

* flake8 lints

Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
telpirion pushed a commit that referenced this pull request Mar 13, 2023
@Strykrol @leahecole @telpirion
dialogflow: remove unused samples + tests [(#3249)](#3249)
70fb0b9 
* dialogflow: delete unused samples and corresponding tests for context management

* dialogflow: delete unused samples and corresponding tests for detecting intent with model selection

* dialogflow: delete unused samples for document management

* dialogflow: clean up document management whitespace

* dialogflow: delete unused samples for entity management

* dialogflow: delete tests for deleted entity management samples

* dialogflow: delete tests for deleted document  management samples

* dialogflow: delete unused samples and corresponding tests for entity type management

* dialogflow: delete unused samples and corresponding tests for session entity type management and entity type management

* dialogflow: delete unused samples and corresponding tests for knowledge base management

* flake8 lints

Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
vchudnov-g pushed a commit to googleapis/google-cloud-python that referenced this pull request Sep 20, 2023
@Strykrol @leahecole @busunkim96
dialogflow: remove unused samples + tests [(#3249)](GoogleCloudPlatfo…
c3e6909 
…rm/python-docs-samples#3249)

* dialogflow: delete unused samples and corresponding tests for context management

* dialogflow: delete unused samples and corresponding tests for detecting intent with model selection

* dialogflow: delete unused samples for document management

* dialogflow: clean up document management whitespace

* dialogflow: delete unused samples for entity management

* dialogflow: delete tests for deleted entity management samples

* dialogflow: delete tests for deleted document  management samples

* dialogflow: delete unused samples and corresponding tests for entity type management

* dialogflow: delete unused samples and corresponding tests for session entity type management and entity type management

* dialogflow: delete unused samples and corresponding tests for knowledge base management

* flake8 lints

Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nnegrey nnegrey nnegrey approved these changes

@gguuss gguuss gguuss approved these changes

@tmatsuo tmatsuo tmatsuo approved these changes

@sirtorry sirtorry Awaiting requested review from sirtorry

@telpirion telpirion Awaiting requested review from telpirion

Assignees

@gguuss gguuss

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Strykrol @tmatsuo @gguuss @nnegrey @googlebot @kokoro-team @leahecole