Adding test for taskqueue pull worker. Fixes #254 #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I65d943bd0ecba1251d46e1d028722bbf685e0251
googlebot
added
the
cla: yes
| @@ -31,3 +32,11 @@ def test_app(testbed): | |||
| tasks = tq_stub.get_filtered_tasks() | |||
| assert len(tasks) == 1 | |||
| assert tasks[0].name == 'task1' | |||
|
|
|||
| with mock.patch('main.update_counter') as mock_update: | |||
| # Force update to fail, otherwise the loop will go forever. | |||
There was a problem hiding this comment.
I'm probably missing some context, but is it not weird to have a worker that polls indefinitely? I'd expect a cron job or something instead, which you can at least cancel?
|
LGTM |
|
lgtm |
|
Travis is being exceptionally slow today. I verified locally. |
rsamborski
pushed a commit
that referenced
this pull request
Nov 8, 2022
8 tasks
rsamborski
pushed a commit
that referenced
this pull request
Nov 8, 2022
donmccasland
pushed a commit
that referenced
this pull request
Nov 8, 2022
8 tasks
engelke
pushed a commit
that referenced
this pull request
Nov 9, 2022
dandhlee
pushed a commit
that referenced
this pull request
Nov 9, 2022
m-strzelczyk
added a commit
that referenced
this pull request
Nov 9, 2022
8 tasks
dandhlee
pushed a commit
that referenced
this pull request
Nov 10, 2022
donmccasland
pushed a commit
that referenced
this pull request
Nov 11, 2022
* chore(python): drop python 3.6 Source-Link: googleapis/synthtool@4f89b13 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:e7bb19d47c13839fe8c147e50e02e8b6cf5da8edd1af8b82208cd6f66cc2829c * add api_description to .repo-metadata.json * require python 3.7+ in setup.py * remove python 3.6 sample configs * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * trigger CI Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>
8 tasks
rsamborski
pushed a commit
that referenced
this pull request
Nov 11, 2022
rsamborski
pushed a commit
that referenced
this pull request
Nov 14, 2022
msampathkumar
pushed a commit
that referenced
this pull request
Nov 14, 2022
* chore(deps): update dependency google-cloud-dataproc to v3.3.0 * remove pin for python 3.6 Co-authored-by: Anthonios Partheniou <partheniou@google.com>
8 tasks
dandhlee
pushed a commit
that referenced
this pull request
Nov 14, 2022
dandhlee
pushed a commit
that referenced
this pull request
Nov 16, 2022
8 tasks
telpirion
pushed a commit
that referenced
this pull request
Nov 16, 2022
Source-Link: googleapis/synthtool@82f5cb2 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:5d8da01438ece4021d135433f2cf3227aa39ef0eaccc941d62aa35e6902832ae Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>
arbrown
pushed a commit
that referenced
this pull request
Nov 17, 2022
Source-Link: googleapis/synthtool@82f5cb2 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:5d8da01438ece4021d135433f2cf3227aa39ef0eaccc941d62aa35e6902832ae Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>
8 tasks
dandhlee
pushed a commit
that referenced
this pull request
Nov 17, 2022
Source-Link: googleapis/synthtool@82f5cb2 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:5d8da01438ece4021d135433f2cf3227aa39ef0eaccc941d62aa35e6902832ae Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>
dandhlee
pushed a commit
that referenced
this pull request
Nov 18, 2022
Source-Link: googleapis/synthtool@82f5cb2 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:5d8da01438ece4021d135433f2cf3227aa39ef0eaccc941d62aa35e6902832ae Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>
dandhlee
pushed a commit
that referenced
this pull request
Jan 26, 2023
* chore(python): drop python 3.6 Source-Link: googleapis/synthtool@4f89b13 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:e7bb19d47c13839fe8c147e50e02e8b6cf5da8edd1af8b82208cd6f66cc2829c * add api_description to .repo-metadata.json * require python 3.7+ in setup.py * remove python 3.6 sample configs * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * trigger CI Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>
telpirion
pushed a commit
that referenced
this pull request
Mar 13, 2023
* chore(python): drop python 3.6 Source-Link: googleapis/synthtool@4f89b13 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:e7bb19d47c13839fe8c147e50e02e8b6cf5da8edd1af8b82208cd6f66cc2829c * add api_description to .repo-metadata.json * require python 3.7+ in setup.py * remove python 3.6 sample configs * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * trigger CI Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.