Adding tests for managed_vms/analytics. Fixes #180 #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
| def app(monkeypatch): | ||
| monkeypatch.setenv('GA_TRACKING_ID', '1234') | ||
|
|
||
| import main |
There was a problem hiding this comment.
I assume this has something to do with monkeypathcing>
There was a problem hiding this comment.
yar, follows the same pattern at managed_vms/mailjet/main_test.py. Basically you can't import main until the env vars are patched. This is actually a common pattern in test fixtures - hide how the actual object constructed from the tests.
Change-Id: I8f049927e81f6786d1221a867539b64a2e5245db
theacodes
force-pushed
the
analytics-tests
branch
from
3ace55f
to
2ab84ef
Compare
|
lgtm |
donmccasland
pushed a commit
that referenced
this pull request
Nov 8, 2022
8 tasks
dandhlee
pushed a commit
that referenced
this pull request
Nov 9, 2022
arbrown
pushed a commit
that referenced
this pull request
Nov 14, 2022
8 tasks
dandhlee
pushed a commit
that referenced
this pull request
Nov 15, 2022
8 tasks
Sita04
pushed a commit
that referenced
this pull request
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.