Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

translate: fix glossary leak issue #3572

Merged
merged 14 commits into from
May 1, 2020
Merged

translate: fix glossary leak issue #3572

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
aa9246d
fix glossary leak issue
munkhuushmgl Apr 28, 2020
35e3f3d
removed try/catch from teardown methods, removed sample_ prefix from …
munkhuushmgl Apr 28, 2020
7eff49d
added specific exceptions to tests, added backoff tags to tests
munkhuushmgl Apr 28, 2020
0f4d4c1
Merge branch 'master' into fix-glossary-leak
munkhuushmgl Apr 28, 2020
ccb9478
fixed the lint issues
munkhuushmgl Apr 28, 2020
cfdd836
Merge branch 'fix-glossary-leak' of https://github.com/munkhuushmgl/p…
munkhuushmgl Apr 28, 2020
77867f0
reordered imports
munkhuushmgl Apr 28, 2020
2a0d5f5
Merge branch 'master' into fix-glossary-leak
munkhuushmgl Apr 28, 2020
aed1b82
moved backoff inside methd and removed Retry
munkhuushmgl Apr 29, 2020
ab773f3
updated branch
munkhuushmgl Apr 29, 2020
b3f2950
Merge branch 'master' into fix-glossary-leak
munkhuushmgl Apr 29, 2020
6d0f003
corrected import nit
munkhuushmgl May 1, 2020
6a8ac5e
Merge branch 'fix-glossary-leak' of https://github.com/munkhuushmgl/p…
munkhuushmgl May 1, 2020
b8267ef
Merge branch 'master' into fix-glossary-leak
munkhuushmgl May 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion translate/cloud-client/translate_v3_list_glossary_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ def glossary():
yield glossary_id

try:
translate_v3_delete_glossary.sample_delete_glossary(PROJECT_ID, glossary_id)
translate_v3_delete_glossary.delete_glossary(PROJECT_ID, glossary_id)
except Exception:
pass
munkhuushmgl marked this conversation as resolved.
Show resolved Hide resolved

Expand Down