Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added script that manages a set of rolling backups. #381

Closed
wants to merge 5 commits into from

Conversation

aegrumet
Copy link

No description provided.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Jun 23, 2016
@@ -0,0 +1,152 @@
#!/usr/bin/python

# pip install --upgrade google-api-python-client
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move these to a requirements.txt file.

@theacodes
Copy link
Contributor

@aegrumet finished a first pass. Let me know when you're ready for another round and feel free to reach out if you have any questions.

We'll also have to get a test written here, but let's resolve my existing comments first.

@aegrumet
Copy link
Author

Updated with all requested changes. Test cases still TODO.

import pytz


DISK_ZONE_MAP = {}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two newlines after this, please.

@theacodes
Copy link
Contributor

This is looking good, do you want to take a stab at writing tests or do you want to leave that to us?

@aegrumet
Copy link
Author

Happy to give it a shot -- feel free to point me to any existing test code
to pattern after.

Also, just as a heads up, I typically iterate on this code outside of work
hours, so it'll be a bit of time before the next update.

On Mon, Jun 27, 2016 at 9:52 AM, Jon Wayne Parrott <notifications@github.com

wrote:

This is looking good, do you want to take a stab at writing tests or do
you want to leave that to us?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#381 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AByoB-RKXLuAevnd8z4BB_-M7qXUNufMks5qP_-8gaJpZM4I8dWW
.

http://blog.grumet.net/about

@theacodes
Copy link
Contributor

feel free to point me to any existing test code
to pattern after.

This entire repository is managed by nox. I'd pattern your tests after this one.

Once you create that file, you can run the tests for just that sample using:

export GCLOUD_PROJECT=your-project-id
nox -s lint
nox -s tests -- compute/backup

There's big guide in TESTING.md but that's more for testing the whole shebang. Feel free to reach out to me via Hangouts if you need help getting things up and running.

Also, just as a heads up, I typically iterate on this code outside of work
hours, so it'll be a bit of time before the next update.

No worries. It'll go at whatever pace you feel comfortable with.

@theacodes
Copy link
Contributor

Closing this as it's rather old, if you're still interested in contributing this, please feel free to re-open or open a new PR.

@theacodes theacodes closed this Feb 27, 2017
telpirion pushed a commit that referenced this pull request Nov 16, 2022
Source-Link: googleapis/synthtool@1b71c10
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:00c9d764fd1cd56265f12a5ef4b99a0c9e87cf261018099141e2ca5158890416

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
dandhlee pushed a commit that referenced this pull request Nov 18, 2022
Source-Link: googleapis/synthtool@1b71c10
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:00c9d764fd1cd56265f12a5ef4b99a0c9e87cf261018099141e2ca5158890416

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
engelke pushed a commit that referenced this pull request Nov 28, 2022
chore: Adding support for pytest-xdist and pytest-parallel

Source-Link: googleapis/synthtool@38e11ad
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:4e1991042fe54b991db9ca17c8fb386e61b22fe4d1472a568bf0fcac85dcf5d3
dandhlee pushed a commit that referenced this pull request Nov 29, 2022
chore: Adding support for pytest-xdist and pytest-parallel

Source-Link: googleapis/synthtool@38e11ad
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:4e1991042fe54b991db9ca17c8fb386e61b22fe4d1472a568bf0fcac85dcf5d3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: no This human has *not* signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants