-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add note about preference of stream() to get() #3972
Merged
tmatsuo
merged 5 commits into
GoogleCloudPlatform:master
from
sdlin:mention-get-deprecation
Jun 5, 2020
Merged
chore: add note about preference of stream() to get() #3972
tmatsuo
merged 5 commits into
GoogleCloudPlatform:master
from
sdlin:mention-get-deprecation
Jun 5, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
Jun 5, 2020
BenWhitehead
approved these changes
Jun 5, 2020
BenWhitehead
added
kokoro:run
Add this label to force Kokoro to re-run the tests.
automerge
Merge the pull request once unit tests and other checks pass.
labels
Jun 5, 2020
BenWhitehead
requested changes
Jun 5, 2020
kokoro-team
removed
the
kokoro:run
Add this label to force Kokoro to re-run the tests.
label
Jun 5, 2020
BenWhitehead
approved these changes
Jun 5, 2020
BenWhitehead
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Jun 5, 2020
BenWhitehead
changed the title
Add note about CollectionRef get deprecation
chore: add note about preference of stream() to get()
Jun 5, 2020
kokoro-team
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Jun 5, 2020
busunkim96
approved these changes
Jun 5, 2020
Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR |
BenWhitehead
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Jun 5, 2020
kokoro-team
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Jun 5, 2020
tmatsuo
added
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
and removed
automerge
Merge the pull request once unit tests and other checks pass.
labels
Jun 5, 2020
kokoro-team
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Jun 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This snippet is used in these docs:
https://cloud.google.com/firestore/docs/query-data/queries#python_3
Which say:
That's true for the other languages, but not for Python, which has deprecated get() and replaced it with stream(), based on these docs:
https://googleapis.dev/python/firestore/latest/collection.html#google.cloud.firestore_v1.collection.CollectionReference.get