Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate code from googleapis/python-batch #8453

Merged
merged 41 commits into from
Nov 15, 2022
Merged

Conversation

m-strzelczyk
Copy link
Contributor

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

parthea and others added 25 commits July 4, 2022 17:50
- [ ] Regenerate this pull request now.

PiperOrigin-RevId: 472561635

Source-Link: googleapis/googleapis@332ecf5

Source-Link: https://github.com/googleapis/googleapis-gen/commit/4313d682880fd9d7247291164d4e9d3d5bd9f177
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDMxM2Q2ODI4ODBmZDlkNzI0NzI5MTE2NGQ0ZTlkM2Q1YmQ5ZjE3NyJ9
* docs(samples): Adding basic code samples + tests

* Checking something

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Fixing noxfile

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Fixing noxfile with new test detection

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Trying to understand what's wrong

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* use latest post processor image

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Fixing the requirements

* Making tests more resilent

* Improving tests

* Tests no longer use logging

* Another fix...

* Fixing lint problems

* Fixing tests

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
- [ ] Regenerate this pull request now.

PiperOrigin-RevId: 474571730

Source-Link: googleapis/googleapis@5a9ee4d

Source-Link: https://github.com/googleapis/googleapis-gen/commit/ceafe521f137680fdee2f9ca9e1947cdd825070d
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiY2VhZmU1MjFmMTM3NjgwZmRlZTJmOWNhOWUxOTQ3Y2RkODI1MDcwZCJ9

fix(deps): require google-api-core>=1.33.1,>=2.8.0
fix(deps): require protobuf >= 3.20.1
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
* chore: update gapic-generator-python to 1.4.3 with test fixes

PiperOrigin-RevId: 475399737

Source-Link: googleapis/googleapis@4c4a9a2

Source-Link: https://github.com/googleapis/googleapis-gen/commit/72fdb5ae55a4d6583893a3e57b7ef264850d06cd
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNzJmZGI1YWU1NWE0ZDY1ODM4OTNhM2U1N2I3ZWYyNjQ4NTBkMDZjZCJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
PiperOrigin-RevId: 475580307

Source-Link: googleapis/googleapis@dbc83bd

Source-Link: https://github.com/googleapis/googleapis-gen/commit/26c120594d6049d40061023cae345da80181077c
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMjZjMTIwNTk0ZDYwNDlkNDAwNjEwMjNjYWUzNDVkYTgwMTgxMDc3YyJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* feat: Add support for V1 and V2 classification models for the V1Beta2 API

PiperOrigin-RevId: 475604619

Source-Link: googleapis/googleapis@044a15c

Source-Link: https://github.com/googleapis/googleapis-gen/commit/410020af934c7248f7804770d6f8ec4571bfa551
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDEwMDIwYWY5MzRjNzI0OGY3ODA0NzcwZDZmOGVjNDU3MWJmYTU1MSJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* chore: update gapic-generator-python-1.4.4 with unit tests generation fixes

PiperOrigin-RevId: 475683078

Source-Link: googleapis/googleapis@df791ce

Source-Link: https://github.com/googleapis/googleapis-gen/commit/ee0ce41cb9bf7bb51005e991022b00ce1bc669d8
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZWUwY2U0MWNiOWJmN2JiNTEwMDVlOTkxMDIyYjAwY2UxYmM2NjlkOCJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
* feat: release SensitiveAction Cloud Logging payload to v1

PiperOrigin-RevId: 476083958

Source-Link: googleapis/googleapis@fafd03f

Source-Link: https://github.com/googleapis/googleapis-gen/commit/79c1b9ce243374735651e72cdebcbed99f5e4e65
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNzljMWI5Y2UyNDMzNzQ3MzU2NTFlNzJjZGViY2JlZDk5ZjVlNGU2NSJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
* docs(samples): Adding sample for bucket mounting

* Fixing lint stuff.
* feat: Add an enum value for raw locations from Apple platforms

PiperOrigin-RevId: 476961484

Source-Link: googleapis/googleapis@695134b

Source-Link: https://github.com/googleapis/googleapis-gen/commit/49457f9e7aae89cfe0491af4dbd9961a90125d32
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDk0NTdmOWU3YWFlODljZmUwNDkxYWY0ZGJkOTk2MWE5MDEyNWQzMiJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
Preparing another code sample. This time for the [`Create a job from a Compute Engine instance template`](https://cloud.google.com/batch/docs/create-run-job#create-job-instance-template) section.
* chore(bazel): update protobuf to v3.21.7

PiperOrigin-RevId: 477955264

Source-Link: googleapis/googleapis@a724450

Source-Link: https://github.com/googleapis/googleapis-gen/commit/4abcbcaec855e74a0b22a4988cf9e0eb61a83094
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNGFiY2JjYWVjODU1ZTc0YTBiMjJhNDk4OGNmOWUwZWI2MWE4MzA5NCJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
* Fixing tests

* docs(samples): Adding samples for list tasks and get task

Co-authored-by: Anthonios Partheniou <partheniou@google.com>
#49)

Co-authored-by: Anthonios Partheniou <partheniou@google.com>
- [ ] Regenerate this pull request now.

docs: Refine comments for deprecated proto fields
docs: Update the API comments about the device_name

PiperOrigin-RevId: 481282173

Source-Link: https://github.com/googleapis/googleapis/commit/e981f84f8a337561a114f8cf7d8f49b2c548228f

Source-Link: https://github.com/googleapis/googleapis-gen/commit/f550f5e45d7b9d5cf92be96db2de5cc2a8088c39
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZjU1MGY1ZTQ1ZDdiOWQ1Y2Y5MmJlOTZkYjJkZTVjYzJhODA4OGMzOSJ9

feat: Enable install_gpu_drivers flag in v1 proto
docs: Refine GPU drivers installation proto description
docs: Refine comments for deprecated proto fields
docs: Update the API comments about the device_name

PiperOrigin-RevId: 481212993

Source-Link: https://github.com/googleapis/googleapis/commit/b037bb3b4ed91bdbdcc6e9ad9d3d641d914b93d2

Source-Link: https://github.com/googleapis/googleapis-gen/commit/60e247bd1082e706c42c115453214b9fb0354864
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNjBlMjQ3YmQxMDgyZTcwNmM0MmMxMTU0NTMyMTRiOWZiMDM1NDg2NCJ9
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
* docs(samples): Adding code samples for log reading

Co-authored-by: Anthonios Partheniou <partheniou@google.com>
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Nov 3, 2022
@nicain nicain marked this pull request as ready for review November 3, 2022 16:03
Copy link
Collaborator

@dandhlee dandhlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, verified compute has existing CODEOWNERS and blunderbuss. All other settings look good, one comment.

noxfile-template.py Outdated Show resolved Hide resolved
Copy link
Contributor

@engelke engelke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dandhlee dandhlee added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 10, 2022
@dandhlee
Copy link
Collaborator

Will verify that additional tests don't run first.

noxfile-template.py Outdated Show resolved Hide resolved
@dandhlee dandhlee added kokoro:run Add this label to force Kokoro to re-run the tests. snippet-bot:force-run Force snippet-bot runs its logic owlbot:run Add this label to trigger the Owlbot post processor. labels Nov 14, 2022
@snippet-bot snippet-bot bot removed the snippet-bot:force-run Force snippet-bot runs its logic label Nov 14, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 14, 2022
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Nov 14, 2022
Copy link
Collaborator

@dandhlee dandhlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just realized - any reason why this is under compute/batch? We're labeling under products and not by ownership.

Copy link
Collaborator

@dandhlee dandhlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget CODEOWNERS and blunderbuss entry for api: batch!

@dandhlee dandhlee removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 15, 2022
Copy link
Collaborator

@dandhlee dandhlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@dandhlee dandhlee merged commit d73bcf6 into main Nov 15, 2022
@dandhlee dandhlee deleted the python-batch-migration branch November 15, 2022 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants