Skip to content
This repository has been archived by the owner on Jul 18, 2024. It is now read-only.

CLI general location support #141

Closed
jasonborg opened this issue May 16, 2023 · 0 comments · Fixed by #143
Closed

CLI general location support #141

jasonborg opened this issue May 16, 2023 · 0 comments · Fixed by #143
Assignees

Comments

@jasonborg
Copy link
Contributor

Currently the CLI init command restricts the location to us-central1. However, it is possible to create a Firebase RTDB instances in other regions, which can be found at https://firebase.google.com/docs/projects/locations#rtdb-locations. The CLI should be modified to support these other locations as well.

This issue was motivated by issue #134 .

@jasonborg jasonborg self-assigned this May 16, 2023
@jasonborg jasonborg changed the title Remove CLI location restriction CLI general location support May 16, 2023
jasonborg added a commit that referenced this issue May 16, 2023
jasonborg added a commit that referenced this issue May 18, 2023
This change allows the user to specify an arbitrary region via the `--location` option to the `init` command. The `--location` option previously existed, however it only allowed the default value of `us-central1`. While the URL of databases in different regions will have different naming conventions, the CLI already made no assumptions in this regard and no extra changes were required to find the DB URL to use. The changes were the following:

- The `init` command no longer enforces the default of `us-central1` for the `--location` argument.
- Some enhancements to checks and user messages on errors were added for the `init` command when `--location` is used.
- The README was updated with documentation regarding regions

fixes #134
fixes #141

---------

Co-authored-by: James McTavish <mctavish@google.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant