scripts to publish javadoc and doc to cloud-rad #1317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iling -SNAPSHOT from version.
zhumin8
force-pushed
the
docfx-test-3.5
branch
from
00e031b to
db6ee6e
Compare
|
force-pushed after rebase. |
elefeint
suggested changes
Nov 9, 2022
mpeddada1
reviewed
Nov 9, 2022
.kokoro/publish_javadoc11.sh
Outdated
Comment on lines
25
to
28
| python3 -m pip install --upgrade six | ||
| python3 -m pip install --upgrade protobuf | ||
| python3 -m pip install gcp-docuploader==0.6.2 | ||
|
|
There was a problem hiding this comment.
The public_javadoc scripts in googleapis/ were recently migrated to use a requirements.txt file with hash checking to securely install dependencies. Maybe we could do the same here? Here's an example: googleapis/synthtool#1588
There was a problem hiding this comment.
updated with changes. Test run succeeded.
|
Kudos, SonarCloud Quality Gate passed!
|
mpeddada1
approved these changes
Nov 9, 2022
elefeint
approved these changes
Nov 9, 2022
zhumin8
added a commit
that referenced
this pull request
Jul 7, 2023
As discussed offline, removing markdown documentation and related files that preps to publish them. These markdown style documentation and scripts introduced in #1317 were to publish documentation but is not published yet. The markdown style documentations were created and kept in parallel to asciidoc ones and creates toil when updates needed for docs. This pr removes them and kept snapshot before removal in [branch](https://github.com/GoogleCloudPlatform/spring-cloud-gcp/tree/md-docs). removed: - md docs - scripts to upload them - `docfx` profile from `pom.xml`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding kokoro scripts and related changes needed to assemble and upload to be published javadoc and documentation to cloud-rad process. Intend to get this in for some final test run before:
Also in this pr: table format changes in
getting-started.mdandpubsub.mdto fix rendered html format issues.update: switch to use a requirements.txt file with hash checking to securely install dependencies with pip install.