Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional fixes for stateful ips in (region)_instance_group_manager #1961

Conversation

modular-magician
Copy link
Collaborator

This fixes an issue omitted during GA promotion: GoogleCloudPlatform/magic-modules#9115, where changes only in stateful_(internal|external)_ip will not trigger a Patch call in the GA provider.
fixes #10908

Also, reenables a test that should no longer flake due to GoogleCloudPlatform/magic-modules#9577
#13430

If this PR is for Terraform, I acknowledge that I have:

Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

Fix issue that changes only in stateful_(internal|external)_ip will not trigger a Patch call in the GA provider for compute_(region_)instance_group_manager

Derived from GoogleCloudPlatform/magic-modules#9965

[upstream:8c99637f3dda5efde734c02861e13e98e54bf4b1]

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician requested a review from a team as a code owner February 16, 2024 15:03
@modular-magician modular-magician requested review from iyabchen and removed request for a team February 16, 2024 15:03
@modular-magician modular-magician merged commit b617bab into GoogleCloudPlatform:main Feb 16, 2024
3 checks passed
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@modular-magician modular-magician deleted the downstream-pr-8c99637f3dda5efde734c02861e13e98e54bf4b1 branch November 18, 2024 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant