Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GKE front matter, bad field docs #1971

Conversation

modular-magician
Copy link
Collaborator

Started as a PR to fix a bad field type as GoogleCloudPlatform/magic-modules#6780 introduced private_endpoint_subnetwork as an optional field but inserted it into the website as a read-only field, but when doing a minor touchup to the page's front matter I ended up reworking it pretty much entirely from

image

to

image

Release Note Template for Downstream PRs (will be copied)

Derived from GoogleCloudPlatform/magic-modules#10018

* Fix GKE front matter, bad field docs

* Update container_cluster.html.markdown

[upstream:f25a214012dc398a6c1a07531a7ae85e049aa538]

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician requested a review from a team as a code owner February 20, 2024 23:46
@modular-magician modular-magician requested review from iyabchen and removed request for a team February 20, 2024 23:46
@modular-magician modular-magician merged commit c8d9fa5 into GoogleCloudPlatform:main Feb 20, 2024
2 checks passed
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant