Run Firestore index tests in fresh databases. #2067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Run Firestore index tests in fresh databases. This removes the index dependency on creating a document, as creating indexes on a non-existent collection is a valid operation in Firestore. This removes the dependency on a fixed (default) database, which should deflake tests. Fixes #17393. * Move project_id to test_env_vars. * Move project_id to test_env_vars for datastore_mode example. [upstream:7c0a51c93476181d4bd8864fb132d511b2b18995] Signed-off-by: Modular Magician <magic-modules@google.com>
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
modular-magician
deleted the
downstream-pr-7c0a51c93476181d4bd8864fb132d511b2b18995
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the index dependency on creating a document, as creating indexes on a non-existent collection is a valid operation in Firestore.
This removes the dependency on a fixed (default) database, which should deflake tests.
Fixes hashicorp/terraform-provider-google#17393.
Verified with a local execution of
make testacc TEST=./google/services/f irestore TESTARGS='-run=TestAccFirestoreIndex_'Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#10168