Update hashicorp/terraform-plugin-framework, terraform-plugin-mux, terraform-plugin-sdk/v2 to navigate breaking change in provider-defined functions #2087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rraform-plugin-sdk/v2 to navigate breaking change in provider-defined functions (#10109) * Update dependencies to include `hashicorp/terraform-plugin-framework@1.6.0` This diff is the result of running: * go get github.com/hashicorp/terraform-plugin-framework@v1.6.0 * go get github.com/hashicorp/terraform-plugin-mux@v0.15.0 * go get github.com/hashicorp/terraform-plugin-sdk/v2@v2.33.0 * go mod tidy * Update reused 'element from id' logic to use errors instead of diagnostics. Remove use of warnings as a result, opt for debug log instead. * Update project and location from id functions to use errors * Update region_from_zone function to use errors * Update zone_from_id function to use errors * Update region_from_id function to use errors * Upgrade to hashicorp/terraform-plugin-framework v1.6.1 * go get hashicorp/terraform-plugin-framework v1.6.1 * go mod tidy * Improve logging in X_from_id functions when multiple regex matches are found * Fix defect in name_from_id acc test * Update name_from_id function to use errors & use new logging approach * Remove use of Go 1.21 toolchain feature from go.mod * Replace use of tflog with log in provider-defined functions [upstream:f0f29d2702ea01d138615ff87f43194c21379525] Signed-off-by: Modular Magician <magic-modules@google.com>
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
modular-magician
merged commit bb855ab
into
GoogleCloudPlatform:FEATURE-BRANCH-provider-functions
5 checks passed
modular-magician
deleted the
downstream-pr-f0f29d2702ea01d138615ff87f43194c21379525
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades the provider functions to use Errors instead of Diagnostics - this is a breaking change introduced in plugin-framework 1.6.0 . By addressing it now I want to avoid navigating those changes after a function is released.
Impact of the change is that provider-defined functions cannot issue warnings anymore, only errors. I've replaced use of warnings with debug logs.
I wanted the debug log to include information about which function was making the log. This required some refactoring about where we set the function's name, to make it accessible in the Run logic of the individual functions.
Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#10109