Generate changes into TFV instead of TGC #798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Switched to generating terraform-validator / using tfv naming in the ci containers * Updated paths to push changes into converters/google/resources * Reduced line length to make rubocop happy * Re-added tf-conversion handling to generate_downstream * Added missing tfv-tester dockerfile contents * Renamed terraform-validator-tester folder * Make resources folder if it doesn't exist for now * Make rubocop happy with single quotes * Temporary hack to fix base generation for TFV * Marked terraform validator test script as executable * Updated differ for tfv generation Signed-off-by: Modular Magician <magic-modules@google.com>
modular-magician
deleted the
downstream-pr-2b31b184c1b8fc2364594c95826a094e547b4866
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated TFV generation to go into TFV directly instead of into TGC. GoogleCloudPlatform/terraform-validator#331 contains an initial import plus some additional required changes (like changes to go.mod and documentation.) Tests on this PR will not be able to fully pass until that PR is merged.
See GoogleCloudPlatform/terraform-validator#237
Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#5349