Skip to content
This repository has been archived by the owner on Nov 27, 2024. It is now read-only.

Added support for google_vertex_ai_tensorboard resource #1133

Merged
merged 1 commit into from
Nov 17, 2022
Merged

Added support for google_vertex_ai_tensorboard resource #1133

merged 1 commit into from
Nov 17, 2022

Conversation

modular-magician
Copy link
Contributor

Added support for google_vertex_ai_tensorboard resource.
fixes hashicorp/terraform-provider-google#12711

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

`google_vertex_ai_tensorboard`

Derived from GoogleCloudPlatform/magic-modules#6759

@modular-magician
Added support for google_vertex_ai_tensorboard resource (#6759)
dbbc706 
* Added support for  google_vertex_ai_tensorboard resource

* Added full test case for google_vertex_ai_tensorboard resource

* Added import support for google_vertex_ai_tensorboard

* Added Full and Update test cases for google_vertex_ai_tensorboard

* Updated the full test of google_vertex_ai_tensorboard

* Updated examples to include import test for vertex_ai_tensorboard

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician requested a review from a team as a code owner November 17, 2022 20:32
@modular-magician modular-magician requested review from iyabchen and removed request for a team November 17, 2022 20:32
@modular-magician modular-magician merged commit 6d65f11 into GoogleCloudPlatform:main Nov 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@iyabchen iyabchen Awaiting requested review from iyabchen iyabchen is a code owner automatically assigned from GoogleCloudPlatform/terraform-validator-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a terraform resource to set up a managed Tensorboard instance
1 participant
@modular-magician