Skip to content
This repository has been archived by the owner on Nov 27, 2024. It is now read-only.

Conversation

modular-magician
Copy link
Contributor

Closes hashicorp/terraform-provider-google#10536
Closes hashicorp/terraform-provider-google#9065
Closes hashicorp/terraform-provider-google#9068
Supersedes #4811

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

datafusion: add `zone`, `display_name`, `crypto_key_config`, `event_publish_config`, and `enable_rbac` args to `google_data_fusion_instance`
datafusion: add `api_endpoint` and `p4_service_account ` attributes to `google_data_fusion_instance`
google_data_fusion_instance_iam_member
google_data_fusion_instance_iam_binding
google_data_fusion_instance_iam_policy

Derived from GoogleCloudPlatform/magic-modules#6270

@modular-magician modular-magician requested a review from a team as a code owner November 29, 2022 19:03
@modular-magician modular-magician requested review from iyabchen and removed request for a team November 29, 2022 19:03
@modular-magician modular-magician merged commit f4cf9d1 into GoogleCloudPlatform:main Nov 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
1 participant