Skip to content
This repository has been archived by the owner on Nov 27, 2024. It is now read-only.

Conversation

modular-magician
Copy link
Contributor

Related to hashicorp/terraform-provider-google#12912

The sql_database_instance tests that run nightly will frequently fail when they hit the 30 minute timeout. It is potentially more likely for configurations that involve clones and backups, but in any case, if the resource can realistically take >30 minutes to create, then the timeout should be higher, so it is only triggered when something is wrong.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

sql: changed the default create timeout of `google_sql_database_instance` to 40m from 30m

Derived from GoogleCloudPlatform/magic-modules#7118

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician requested a review from a team as a code owner January 13, 2023 01:24
@modular-magician modular-magician requested review from ScottSuarez and removed request for a team January 13, 2023 01:24
@modular-magician modular-magician merged commit 0e95c08 into GoogleCloudPlatform:main Jan 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant