Fix Issue #169 #185
Merged
Fix Issue #169 #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t0rr3sp3dr0
force-pushed
the
patch-1
branch
from
532001f to
1cf19c4
Compare
Signed-off-by: Pedro Tôrres <t0rr3sp3dr0@gmail.com>
t0rr3sp3dr0
force-pushed
the
patch-1
branch
from
1cf19c4 to
8c48ca5
Compare
|
@sergeylanzman, do I have to do something else to get this pull request merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Route53 records
example.comand*.example.commust have different identifiers, otherwise it will result:This is fixed by removing
"*."to""replace rule and then adding"*"to"--"replace rule. While"."will be handled by the"."to"--"existent rule.The problem is described on Issue #169.