providers/alicloud: shouldn't access p.Service in GetConfig() #689
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #681
why
p.Service
is not initialized when we callGetConfig
here:https://github.com/GoogleCloudPlatform/terraformer/blob/master/cmd/import.go#L113-L116
and it's better to use
p.profile
field which is initialized inInit()
:terraformer/providers/alicloud/alicloud_provider.go
Lines 112 to 116 in b9a6ae6