Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Created using Colab #3763

Merged
merged 12 commits into from
Dec 30, 2024
Merged

Created using Colab #3763

merged 12 commits into from
Dec 30, 2024

Conversation

alicechang0909
Copy link
Contributor


Add FeatureStore Feature Monitoring Notebook


REQUIRED: Fill out the below checklists or remove if irrelevant

  1. If you are opening a PR for Official Notebooks under the notebooks/official folder, follow this mandatory checklist:
  • Use the notebook template as a starting point.
  • Follow the style and grammar rules outlined in the above notebook template.
  • Verify the notebook runs successfully in Colab since the automated tests cannot guarantee this even when it passes.
  • Passes all the required automated checks. You can locally test for formatting and linting with these instructions.
  • You have consulted with a tech writer to see if tech writer review is necessary. If so, the notebook has been reviewed by a tech writer, and they have approved it.
  • The Jupyter notebook cleans up any artifacts it has created (datasets, ML models, endpoints, etc) so as not to eat up unnecessary resources.

@alicechang0909 alicechang0909 requested a review from a team as a code owner December 20, 2024 00:33
@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@kazunori279 kazunori279 self-requested a review December 21, 2024 00:38
kazunori279
kazunori279 approved these changes Dec 21, 2024
View reviewed changes
Copy link

@kazunori279 kazunori279 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

auto-merge was automatically disabled December 21, 2024 00:51

Head branch was pushed to by a user without write access

@kweinmeister
Copy link
Contributor

/gcbrun

@alicechang0909
Copy link
Contributor Author

/gcbrun

2 similar comments
@junkourata
Copy link
Contributor

/gcbrun

@gericdong
Copy link
Contributor

/gcbrun

@inardini inardini self-requested a review December 30, 2024 18:58
inardini
inardini approved these changes Dec 30, 2024
View reviewed changes
Copy link
Collaborator

@inardini inardini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alicechang0909 alicechang0909 added this pull request to the merge queue Dec 30, 2024
Merged via the queue into GoogleCloudPlatform:main with commit 9621877 Dec 30, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gericdong gericdong gericdong left review comments

@inardini inardini inardini approved these changes

@kazunori279 kazunori279 kazunori279 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@alicechang0909 @kweinmeister @junkourata @gericdong @kazunori279 @inardini