This repository has been archived by the owner on Mar 27, 2024. It is now read-only.
Fix concurrent map write for hardlink #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antechrestos
force-pushed
the
fix/concurrent_map_write
branch
from
702efa2
to
326aa87
Compare
4 tasks
antechrestos
force-pushed
the
fix/concurrent_map_write
branch
from
326aa87
to
89dcb85
Compare
|
@nkubala any feedback on this? |
nkubala
approved these changes
Feb 13, 2020
There was a problem hiding this comment.
@antechrestos sorry for the late review on this one, but this LGTM
|
@nkubala no problem 😊 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change uses
sync.Mapas suggested in #323 . It also uses async.atomic.Valuecontainer for any error that might happens while loop iteration