Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the "user" metadata. Related to #80. #274

Merged
merged 1 commit into from
Apr 20, 2021

Conversation

dduportal
Copy link
Contributor

Hello there! Thanks for this cool tool!

The issue #80 mentions some metadata Image fields that are not available.

This PR implements the support for the field "user" which defines the default user of a container.
This is really useful when you want to check that an image is not launching container as root by default :)

Signed-off-by: Damien Duportal damien.duportal@gmail.com

Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
Copy link

@deedubs deedubs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would to replace all my:

commandTests:
  - name: "whoami"
    command: "whoami"
    expectedOutput: ["app"]

with

metadataTest:
  user: app

Copy link
Contributor

@nkubala nkubala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution @dduportal!

@nkubala nkubala merged commit 75451d1 into GoogleContainerTools:master Apr 20, 2021
@dduportal dduportal deleted the feat/meta-user branch April 20, 2021 17:40
@gregwhorley
Copy link

Any estimated timeline on the next release with this enhancement? The readme states this field is valid in the Metadata test example, but I get field user not found in type v2.MetadataTest when I have this in my test definition yaml:

schemaVersion: "2.0.0"

metadataTest:
  user: "nameOfMyUser"

@dduportal
Copy link
Contributor Author

Good question @gregwhorley !

Ping @nkubala about the release?

@edouard-lopez
Copy link

As of October 14th 2021 it's still present as no new released happened :(

related #285

@dduportal
Copy link
Contributor Author

Release 0.11.0 had been released the 09th of november with this change. Thanks maintainer team!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants