Allow parsing of scratch as an image string (#1792)

GoogleContainerTools · Jun 20, 2019 · ab22479 · ab22479
1 parent 23beaa1
commit ab22479
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/jib-core/src/main/java/com/google/cloud/tools/jib/api/ImageReference.java b/jib-core/src/main/java/com/google/cloud/tools/jib/api/ImageReference.java
@@ -92,6 +92,10 @@ public class ImageReference {
    * @throws InvalidImageReferenceException if {@code reference} is formatted incorrectly
    */
   public static ImageReference parse(String reference) throws InvalidImageReferenceException {
+    if (reference.equals("scratch")) {
+      return ImageReference.scratch();
+    }
+
     Matcher matcher = REFERENCE_PATTERN.matcher(reference);
 
     if (!matcher.find() || matcher.groupCount() < 4) {

diff --git a/jib-core/src/main/java/com/google/cloud/tools/jib/configuration/BuildConfiguration.java b/jib-core/src/main/java/com/google/cloud/tools/jib/configuration/BuildConfiguration.java
@@ -244,7 +244,9 @@ public BuildConfiguration build() throws IOException {
 
       switch (missingFields.size()) {
         case 0: // No errors
-          if (Preconditions.checkNotNull(baseImageConfiguration).getImage().usesDefaultTag()) {
+          Preconditions.checkNotNull(baseImageConfiguration);
+          if (baseImageConfiguration.getImage().usesDefaultTag()
+              && !baseImageConfiguration.getImage().isScratch()) {
             eventHandlers.dispatch(
                 LogEvent.warn(
                     "Base image '"

diff --git a/jib-core/src/test/java/com/google/cloud/tools/jib/api/ImageReferenceTest.java b/jib-core/src/test/java/com/google/cloud/tools/jib/api/ImageReferenceTest.java
@@ -181,7 +181,8 @@ public void testIsTagDigest() throws InvalidImageReferenceException {
   }
 
   @Test
-  public void testIsScratch() {
+  public void testIsScratch() throws InvalidImageReferenceException {
+    Assert.assertTrue(ImageReference.parse("scratch").isScratch());
     Assert.assertTrue(ImageReference.scratch().isScratch());
     Assert.assertFalse(ImageReference.of("", "scratch", "").isScratch());
     Assert.assertFalse(ImageReference.of(null, "scratch", null).isScratch());