Adds ProgressDisplayGenerator. #1333
Conversation
| "> childLeftDown", | ||
| "> childRight"), | ||
| ProgressDisplayGenerator.generateProgressDisplay( | ||
| 0.5, Arrays.asList(root, childLeft, childLeftDown, childRight))); |
There was a problem hiding this comment.
Hmm... looks like a caller should enumerate all unfinished allocations. So I think the caller will go over every node in the tree and identify which node is unfinished. Knowing that, is it not easy for the caller to identify leaves and pass only leaves?
There was a problem hiding this comment.
The caller would be the one that gets the unfinished allocations from ProgressEventHandler#getUnfinishedAllocations, which gets it from AllocationCompletionTracker. I believe we could have AllocationCompletionTracker just give back the leaf allocations so that the set computation can be optimized away. I'll make a TODO for this optimization.
There was a problem hiding this comment.
Yeah, I think that'd be nice.
...common/src/main/java/com/google/cloud/tools/jib/plugins/common/ProgressDisplayGenerator.java
Outdated
Show resolved
Hide resolved
| "> childLeftDown", | ||
| "> childRight"), | ||
| ProgressDisplayGenerator.generateProgressDisplay( | ||
| 0.5, Arrays.asList(root, childLeft, childLeftDown, childRight))); |
There was a problem hiding this comment.
Yeah, I think that'd be nice.
Part of #1297
ProgressDisplayGeneratorgenerates the displayed text for progress feedback.