Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add file size to dependency filenames to avoid filename collisions #1338

Merged
merged 5 commits into from
Dec 14, 2018
Merged

Add file size to dependency filenames to avoid filename collisions #1338

merged 5 commits into from
Dec 14, 2018

Conversation

TadCordle
Copy link
Contributor

Fixes #810

@TadCordle TadCordle requested a review from a team December 13, 2018 17:05
loosebazooka
loosebazooka approved these changes Dec 14, 2018
View reviewed changes
Copy link
Member

@loosebazooka loosebazooka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, shouldn't affect anyone's build behavior unless they have duplicates 👍

@TadCordle TadCordle merged commit fd72f6f into master Dec 14, 2018
@TadCordle TadCordle deleted the i810-same-module-names branch December 14, 2018 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loosebazooka loosebazooka loosebazooka approved these changes

@coollog coollog coollog left review comments

@briandealwis briandealwis Awaiting requested review from briandealwis

@chanseokoh chanseokoh Awaiting requested review from chanseokoh

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TadCordle @loosebazooka @coollog @chanseokoh @googlebot