Cache compressed local base image layers #1957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he-local-base-layers
…he-local-base-layers
TadCordle
changed the title
…he-local-base-layers
chanseokoh
reviewed
Sep 6, 2019
jib-core/src/main/java/com/google/cloud/tools/jib/builder/steps/ExtractTarStep.java
Outdated
Show resolved
Hide resolved
jib-core/src/main/java/com/google/cloud/tools/jib/builder/steps/ExtractTarStep.java
Outdated
Show resolved
Hide resolved
|
I think this should be mostly good for review. |
2 tasks
chanseokoh
reviewed
Sep 10, 2019
jib-core/src/main/java/com/google/cloud/tools/jib/builder/steps/ExtractTarStep.java
Outdated
Show resolved
Hide resolved
Hmm, I did accidentally start the skaffold fix on this branch so I needed to revert some stuff, I must have messed up and renamed this branch instead of making a new one. I'll fix it tomorrow. |
chanseokoh
approved these changes
Sep 12, 2019
There was a problem hiding this comment.
Hopefully one day, we restructure the cache to have consistency between local and remote layers in cache and remove some duplicate code, but that sounds like needing more thoughts (#1982).
jib-core/src/test/java/com/google/cloud/tools/jib/cache/CacheStorageWriterTest.java
Outdated
Show resolved
Hide resolved
jib-core/src/test/java/com/google/cloud/tools/jib/cache/CacheStorageReaderTest.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1912.
I did some manual tests and here is how long each build took, running
jibBuildDockeron a small test project with the following base images.docker://gcr.io/distroless/javatar://distroless.tardocker://openjdk:8tar://openjdk.tarThis is a pretty big improvement; it seems the next bottleneck to overcome is the
docker savethat runs with adocker://base image.