Warns the user if specified mainClass is not a valid Java class. #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -30,6 +30,8 @@ | |||
| /** Immutable configuration options for the builder process. */ | |||
| public class BuildConfiguration { | |||
|
|
|||
| public static final String VALID_JAVA_CLASS_REGEX = "([\\p{L}_$][\\p{L}\\p{N}_$]*\\.)*[\\p{L}_$][\\p{L}\\p{N}_$]*"; | |||
There was a problem hiding this comment.
oh confusing, can you comment on top of this, what this means?
There was a problem hiding this comment.
actually never mind, the tests are good.
| public void testValidJavaClassRegex() { | ||
| Assert.assertTrue("my.Class".matches(BuildConfiguration.VALID_JAVA_CLASS_REGEX)); | ||
| Assert.assertTrue("my.java_Class$valid".matches(BuildConfiguration.VALID_JAVA_CLASS_REGEX)); | ||
| Assert.assertFalse("${start-class}".matches(BuildConfiguration.VALID_JAVA_CLASS_REGEX)); |
There was a problem hiding this comment.
can you verify that is123.valid works?
and that mutliple package items work? abc.xyz.Valid
|
Changed the regex method to rather use the built-in method for checking valid Java identifiers. |
loosebazooka
approved these changes
Apr 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #206
Fixes #170