Add option to specify base image for cli jar command #2972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpeddada1
commented
Jan 6, 2021
jib-cli/src/test/java/com/google/cloud/tools/jib/cli/jar/JarFilesTest.java
Outdated
Show resolved
Hide resolved
chanseokoh
reviewed
Jan 7, 2021
jib-cli/src/main/java/com/google/cloud/tools/jib/cli/jar/JarFiles.java
Outdated
Show resolved
Hide resolved
jib-cli/src/test/java/com/google/cloud/tools/jib/cli/jar/JarFilesTest.java
Outdated
Show resolved
Hide resolved
chanseokoh
reviewed
Jan 7, 2021
jib-cli/src/main/java/com/google/cloud/tools/jib/cli/buildfile/BuildFiles.java
Outdated
Show resolved
Hide resolved
jib-cli/src/main/java/com/google/cloud/tools/jib/cli/ContainerBuilders.java
Outdated
Show resolved
Hide resolved
jib-cli/src/main/java/com/google/cloud/tools/jib/cli/ContainerBuilders.java
Outdated
Show resolved
Hide resolved
jib-cli/src/integration-test/java/com/google/cloud/tools/jib/cli/JarCommandTest.java
Outdated
Show resolved
Hide resolved
jib-cli/src/main/java/com/google/cloud/tools/jib/cli/buildfile/BuildFiles.java
Outdated
Show resolved
Hide resolved
chanseokoh
approved these changes
Jan 7, 2021
jib-cli/src/test/java/com/google/cloud/tools/jib/cli/ContainerBuildersTest.java
Outdated
Show resolved
Hide resolved
loosebazooka
approved these changes
Jan 8, 2021
| throws IOException, InvalidImageReferenceException { | ||
|
|
||
| // Use distroless as the base image. | ||
| JibContainerBuilder containerBuilder = Jib.from("gcr.io/distroless/java"); | ||
| // Use distroless as the default base image. |
There was a problem hiding this comment.
I think here we should try to check if the jar is java8 or java11 and chose the right distroless? (perhaps in a followup PR)
There was a problem hiding this comment.
Yup, good point - we have an issue for this #2871. Will make this change in the next PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2923
This PR adds the
--fromoption to the jib cli jar subcommand. It will be used to specify the desired base image.