[Jib CLI WAR] Implement exploded mode for standard WAR #3226
Conversation
jib-cli/src/main/java/com/google/cloud/tools/jib/cli/ArtifactProcessor.java
Show resolved
Hide resolved
jib-cli/src/main/java/com/google/cloud/tools/jib/cli/ArtifactLayers.java
Show resolved
Hide resolved
| * @param warPath path to WAR file | ||
| * @param targetExplodedWarRoot path to exploded-war root | ||
| * @param warJavaVersion war java version | ||
| * @param appRoot the absolute path of the app on the container |
There was a problem hiding this comment.
We don't provide the --appRoot option yet, right?
There was a problem hiding this comment.
Ah good question. Nope, we don't provide the --appRoot option yet, it will be added when War.class is implemented. This class will only accept appRoot as an input but the idea is to set it in ArtifactProcessors. If a base image is specified then the user is expected to provide the appRoot (otherwise we throw an exception). If a base image is not specified then we create StandardWarExplodedProcessor with the default jetty app root.
There was a problem hiding this comment.
Sounds like a good plan.
If a base image is specified then the user is expected to provide the
appRoot(otherwise we throw an exception).
Maybe throw an exception only when it's not the jetty on Docker Hub. I imagine often you set a base image only to use a tag or digest for jetty, which was the case in #3204.
There was a problem hiding this comment.
Yes, that is a great point! Will have to keep this in mind when implementing ArtifactProcessors
jib-cli/src/main/java/com/google/cloud/tools/jib/cli/war/StandardWarExplodedProcessor.java
Show resolved
Hide resolved
| * @param warPath path to WAR file | ||
| * @param targetExplodedWarRoot path to exploded-war root | ||
| * @param warJavaVersion war java version | ||
| * @param appRoot the absolute path of the app on the container |
There was a problem hiding this comment.
Sounds like a good plan.
If a base image is specified then the user is expected to provide the
appRoot(otherwise we throw an exception).
Maybe throw an exception only when it's not the jetty on Docker Hub. I imagine often you set a base image only to use a tag or digest for jetty, which was the case in #3204.
jib-cli/src/main/java/com/google/cloud/tools/jib/cli/war/StandardWarExplodedProcessor.java
Outdated
Show resolved
Hide resolved
jib-cli/src/main/java/com/google/cloud/tools/jib/cli/war/StandardWarExplodedProcessor.java
Outdated
Show resolved
Hide resolved
Major Changes:
fromJar(already implemented) andfromWar, which will contain logic to select mode processors for JARs and WARs respectively.