Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More samples need to switch to jakarta #3663

Merged
merged 1 commit into from
May 11, 2022
Merged

More samples need to switch to jakarta #3663

merged 1 commit into from
May 11, 2022

Conversation

elefeint
Copy link
Contributor

in #3661, I only fixed jib-cli. After that, more test failures turned up in gradle plugin.

Notes

  • I ought to have switched to Temurin images in the first place.
  • The random-looking configurations { moreLibs } is there because otherwise the tests can be run from root but not from gradle-plugin subroot.

@sonarcloud
Copy link

sonarcloud bot commented May 11, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@elefeint elefeint requested a review from mpeddada1 May 11, 2022 17:37
mpeddada1
mpeddada1 approved these changes May 11, 2022
View reviewed changes
Copy link
Contributor

@mpeddada1 mpeddada1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

@elefeint elefeint merged commit 7c6e5fe into master May 11, 2022
@elefeint elefeint deleted the more-jakarta branch May 11, 2022 17:45
@elefeint elefeint mentioned this pull request May 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpeddada1 mpeddada1 mpeddada1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elefeint @mpeddada1