Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: address windows deadlock issue when determining docker environment info #4288

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

mpeddada1
Copy link
Contributor

For #4267

Reproducer: https://github.com/mpeddada1/windows_deadlock (note that this reproducer doesn't using docker but showcases the same issue observed in #4267). According to the official documentation:

Because some native platforms only provide limited buffer size for standard input and output streams, failure to promptly write the input stream or read the output stream of the subprocess may cause the subprocess to block, or even deadlock.

@mpeddada1 mpeddada1 requested a review from blakeli0 July 10, 2024 21:08
@mpeddada1 mpeddada1 merged commit 18d5c77 into master Jul 19, 2024
11 checks passed
@mpeddada1 mpeddada1 deleted the windows-deadlock branch July 19, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants