Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jib cli] chore: remove duplicate test method for verifying --from argument #4307

Merged
merged 1 commit into from
Sep 9, 2024
Merged

[jib cli] chore: remove duplicate test method for verifying --from argument #4307

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 0 additions & 16 deletions jib-cli/src/integration-test/java/com/google/cloud/tools/jib/cli/JarCommandTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,22 +323,6 @@ public void testSpringBootJar_packagedMode() throws IOException, InterruptedExce
new URL("http://" + HttpRequestTester.fetchDockerHostForHttpRequest() + ":8080"));
}

@Test
public void testJar_baseImageSpecified()
throws IOException, URISyntaxException, InterruptedException {
Path jarPath = Paths.get(Resources.getResource("jarTest/standard/noDependencyJar.jar").toURI());
Integer exitCode =
new CommandLine(new JibCli())
.execute(
"jar",
"--target=docker://cli-gcr-base",
"--from=gcr.io/google-appengine/openjdk:8",
jarPath.toString());
assertThat(exitCode).isEqualTo(0);
String output = new Command("docker", "run", "--rm", "cli-gcr-base").run();
assertThat(output).isEqualTo("Hello World");
}

public static void createJarFile(
String name, String className, String classPath, String mainClass)
throws IOException, URISyntaxException {
Expand Down
Loading