Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds BuildConfiguration#setExtraFilesLayerConfiguration. #480

Merged
merged 28 commits into from
Jul 10, 2018

Conversation

coollog
Copy link
Contributor

@coollog coollog commented Jun 29, 2018

Part of #473

@coollog coollog requested a review from a team July 3, 2018 16:30
@coollog
Copy link
Contributor Author

coollog commented Jul 3, 2018

Will actually merge #503 first, since that makes LayerConfiguration able to take multiple entries.

@loosebazooka
Copy link
Member

Should just generically accept layer configurations? Especially if that works towards our goal of library-fying jib.

@coollog
Copy link
Contributor Author

coollog commented Jul 6, 2018

@loosebazooka okay I can file a separate PR for that since that includes a lot more changes to the codebase.

@coollog
Copy link
Contributor Author

coollog commented Jul 10, 2018

Filed #516 , but we might want to have this first before that so that we can get the extra files feature out sooner.

@coollog coollog merged commit 156bacd into master Jul 10, 2018
@coollog coollog deleted the extra-files-configuration branch July 10, 2018 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants