Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes jibExportDockerContext.targetDir configurable from build.gradle. #492

Merged
merged 2 commits into from
Jul 2, 2018

Conversation

coollog
Copy link
Contributor

@coollog coollog commented Jul 2, 2018

This makes jibExportDockerContext configurable like:

build.gradle:

jibExportDockerContext {
    targetDir = 'my-dir'
}

Whereas before it could only be configured from a command line property --jib.dockerDir

@coollog coollog requested a review from a team July 2, 2018 18:20
Copy link
Contributor

@TadCordle TadCordle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably add this to the changelog

@patflynn
Copy link
Contributor

patflynn commented Jul 2, 2018

@loosebazooka is it gradle custom to allow the user to place build outputs outside of the build directory?

@coollog
Copy link
Contributor Author

coollog commented Jul 2, 2018

Filed #493 to not allow exporting outside of build output directory.

@patflynn
Copy link
Contributor

patflynn commented Jul 2, 2018

@coollog FWIW I'm not strongly opinionated about whether these files should even be considered build outputs. Just asking the question.

@coollog
Copy link
Contributor Author

coollog commented Jul 2, 2018

Yea we'll have exportDockerContext match whatever we decide for the tarball export feature.

@coollog coollog merged commit 4e11674 into master Jul 2, 2018
@coollog coollog deleted the dockercontexttargetdir branch July 10, 2018 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants