-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additionally allow suffix matching for cred lookup #642
Conversation
return registryAuth.auth; | ||
} | ||
return null; | ||
Predicate<String> exactMatch = registry::equals; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 on the ordering. The description in the PR should prob be added to this javadoc.
} | ||
|
||
/** Returns {@link AuthTemplate} matching the given predicate. */ | ||
private AuthTemplate getAuthTemplate(Predicate<String> registryMatch) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: maybe it makes sense to have this one below the other getAuthTemplate
since that one calls this one
Part of #586 (#586 (comment)).
Order of preference for finding a matching credential:
https://
+ registry namehttps://
registry name + arbitrary suffix