Error on invalid jib.httpTimeout values at plugin front-ends #667
Conversation
|
You can start reviewing. Once #656 is merged, I'll change the target base for merging. |
|
Hmm... I just saw the |
|
Also, looks like I should throw |
| try { | ||
| String value = System.getProperty("jib.httpTimeout"); | ||
| if (value != null && Integer.parseInt(value) < 0) { | ||
| throw exceptionFactory.apply("negative value of jib.httpTimeout"); |
There was a problem hiding this comment.
How about a wording of "jib.httpTimeout cannot be negative: -1234" (with the negative value)?
| throw exceptionFactory.apply("negative value of jib.httpTimeout"); | ||
| } | ||
| } catch (NumberFormatException ex) { | ||
| throw exceptionFactory.apply("non-integer value of jib.httpTimeout"); |
There was a problem hiding this comment.
How about a wording of "jib.httpTimeout must be an integer: notaninteger" (with the attempted value)?
| } | ||
| } catch (NumberFormatException ex) { | ||
| throw exceptionFactory.apply("non-integer value of jib.httpTimeout"); | ||
| } |
There was a problem hiding this comment.
Let's include a private constructor for this static utility class.
|
Cools, we'll be able to do a v0.9.7 release after this is merged. |
|
@TadCordle We could probably do the |
To clarify, this is being handled correctly after #650. |
Fixes #582.